From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40144) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UReS0-0008K1-DQ for qemu-devel@nongnu.org; Mon, 15 Apr 2013 04:07:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UReKW-0006iO-2y for qemu-devel@nongnu.org; Mon, 15 Apr 2013 04:00:05 -0400 Received: from hall.aurel32.net ([2001:470:1f15:c4f::1]:48889) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UReKV-0006hk-PX for qemu-devel@nongnu.org; Mon, 15 Apr 2013 03:59:59 -0400 Date: Mon, 15 Apr 2013 09:59:52 +0200 From: Aurelien Jarno Message-ID: <20130415075952.GA11356@ohm.aurel32.net> References: <1365116186-19382-1-git-send-email-rth@twiddle.net> <1365116186-19382-13-git-send-email-rth@twiddle.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <1365116186-19382-13-git-send-email-rth@twiddle.net> Subject: Re: [Qemu-devel] [PATCH v4 12/33] tcg-ppc64: Allow constant first argument to sub List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: av1474@comtv.ru, qemu-devel@nongnu.org On Thu, Apr 04, 2013 at 05:56:05PM -0500, Richard Henderson wrote: > Using SUBFIC for 16-bit signed constants. > > Signed-off-by: Richard Henderson > --- > tcg/ppc64/tcg-target.c | 21 +++++++++++++++++---- > 1 file changed, 17 insertions(+), 4 deletions(-) > > diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c > index 384946b..4da969f 100644 > --- a/tcg/ppc64/tcg-target.c > +++ b/tcg/ppc64/tcg-target.c > @@ -329,6 +329,7 @@ static int tcg_target_const_match (tcg_target_long val, > #define MULLI OPCD( 7) > #define CMPLI OPCD( 10) > #define CMPI OPCD( 11) > +#define SUBFIC OPCD( 8) > > #define LWZU OPCD( 33) > #define STWU OPCD( 37) > @@ -1314,7 +1315,13 @@ static void tcg_out_op (TCGContext *s, TCGOpcode opc, const TCGArg *args, > break; > case INDEX_op_sub_i32: > a0 = args[0], a1 = args[1], a2 = args[2]; > - if (const_args[2]) { > + if (const_args[1]) { > + if (const_args[2]) { > + tcg_out_movi(s, TCG_TYPE_I32, a0, a1 - a2); > + } else { > + tcg_out32(s, SUBFIC | TAI(a0, a2, a1)); > + } > + } else if (const_args[2]) { > a2 = -a2; > goto do_addi_32; > } else { > @@ -1483,7 +1490,13 @@ static void tcg_out_op (TCGContext *s, TCGOpcode opc, const TCGArg *args, > break; > case INDEX_op_sub_i64: > a0 = args[0], a1 = args[1], a2 = args[2]; > - if (const_args[2]) { > + if (const_args[1]) { > + if (const_args[2]) { > + tcg_out_movi(s, TCG_TYPE_I64, a0, a1 - a2); > + } else { > + tcg_out32(s, SUBFIC | TAI(a0, a2, a1)); > + } > + } else if (const_args[2]) { > a2 = -a2; > goto do_addi_64; > } else { > @@ -1639,7 +1652,7 @@ static const TCGTargetOpDef ppc_op_defs[] = { > { INDEX_op_divu_i32, { "r", "r", "r" } }, > { INDEX_op_rem_i32, { "r", "r", "r" } }, > { INDEX_op_remu_i32, { "r", "r", "r" } }, > - { INDEX_op_sub_i32, { "r", "r", "ri" } }, > + { INDEX_op_sub_i32, { "r", "rI", "ri" } }, > { INDEX_op_and_i32, { "r", "r", "ri" } }, > { INDEX_op_or_i32, { "r", "r", "ri" } }, > { INDEX_op_xor_i32, { "r", "r", "ri" } }, > @@ -1655,7 +1668,7 @@ static const TCGTargetOpDef ppc_op_defs[] = { > { INDEX_op_not_i32, { "r", "r" } }, > > { INDEX_op_add_i64, { "r", "r", "rT" } }, > - { INDEX_op_sub_i64, { "r", "r", "rT" } }, > + { INDEX_op_sub_i64, { "r", "rI", "rT" } }, > { INDEX_op_and_i64, { "r", "r", "rU" } }, > { INDEX_op_or_i64, { "r", "r", "rU" } }, > { INDEX_op_xor_i64, { "r", "r", "rU" } }, Reviewed-by: Aurelien Jarno -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net