From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH 3/7] ARM: exynos: add missing properties for combiner IRQs Date: Mon, 15 Apr 2013 10:41:44 +0200 Message-ID: <201304151041.44805.arnd@arndb.de> References: <1365775405-115297-1-git-send-email-arnd@arndb.de> <1365775405-115297-4-git-send-email-arnd@arndb.de> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from moutng.kundenserver.de ([212.227.17.9]:61912 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934635Ab3DOIlw (ORCPT ); Mon, 15 Apr 2013 04:41:52 -0400 In-Reply-To: Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Sachin Kamat Cc: Kukjin Kim , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, Chanho Park , Tushar Behera , Tomasz Figa , Thomas Abraham , Kyungmin Park On Monday 15 April 2013, Sachin Kamat wrote: > On 12 April 2013 19:33, Arnd Bergmann wrote: > > > > combiner:interrupt-controller@10440000 { > > + combiner-nr = <16>; > > I think this should be "samsung,combiner-nr" > Without this i see the following message in boot log: > "combiner_of_init: number of combiners not specified" Right, thanks! > > diff --git a/arch/arm/boot/dts/exynos4212.dtsi b/arch/arm/boot/dts/exynos4212.dtsi > > index 36d4299..f83c3c1 100644 > > --- a/arch/arm/boot/dts/exynos4212.dtsi > > +++ b/arch/arm/boot/dts/exynos4212.dtsi > > @@ -26,6 +26,15 @@ > > cpu-offset = <0x8000>; > > }; > > > > + interrupt-controller@10440000 { > > Don't we need a node name here (combiner:interrupt-controller@10440000)? Why? The "combiner:" part is just a label. Actually I think the preferred syntax is &combiner { samsung,combiner-nr = <18>; }; which is much shorter to write, but I did not want to change the style used in the rest of the file. > > + combiner-nr = <18>; > ^^^^^^^^^^^ > nit: tabs instead of space would look better. I fixed that up locally, but I think I sent out the wrong version. > > diff --git a/arch/arm/boot/dts/exynos4412.dtsi b/arch/arm/boot/dts/exynos4412.dtsi > > index d75c047..4cb657e 100644 > > --- a/arch/arm/boot/dts/exynos4412.dtsi > > +++ b/arch/arm/boot/dts/exynos4412.dtsi > > @@ -26,6 +26,15 @@ > > cpu-offset = <0x4000>; > > }; > > > > + interrupt-controller@10440000 { > > + combiner-nr = <20>; > Same as above (for exynos4212.dtsi). > > > + interrupts = <0 0 0>, <0 1 0>, <0 2 0>, <0 3 0>, > > + <0 4 0>, <0 5 0>, <0 6 0>, <0 7 0>, > > + <0 8 0>, <0 9 0>, <0 10 0>, <0 11 0>, > > + <0 12 0>, <0 13 0>, <0 14 0>, <0 15 0>, > > + <0 107 0>, <0 108 0>>, <0 48 0>, <0 42 0>; > ^^^ > Syntax error. > > We have a combiner node defined in exynos4x12.dtsi. With the bindings > now defined separately in 4212 and 4412 dtsi files, probably the one > in 4x12 could be dropped? I did not see that one, but it seems to have the wrong numbers in the last four interrupt specifiers. I think it would be better to just fix that one and keep using it. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Mon, 15 Apr 2013 10:41:44 +0200 Subject: [PATCH 3/7] ARM: exynos: add missing properties for combiner IRQs In-Reply-To: References: <1365775405-115297-1-git-send-email-arnd@arndb.de> <1365775405-115297-4-git-send-email-arnd@arndb.de> Message-ID: <201304151041.44805.arnd@arndb.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Monday 15 April 2013, Sachin Kamat wrote: > On 12 April 2013 19:33, Arnd Bergmann wrote: > > > > combiner:interrupt-controller at 10440000 { > > + combiner-nr = <16>; > > I think this should be "samsung,combiner-nr" > Without this i see the following message in boot log: > "combiner_of_init: number of combiners not specified" Right, thanks! > > diff --git a/arch/arm/boot/dts/exynos4212.dtsi b/arch/arm/boot/dts/exynos4212.dtsi > > index 36d4299..f83c3c1 100644 > > --- a/arch/arm/boot/dts/exynos4212.dtsi > > +++ b/arch/arm/boot/dts/exynos4212.dtsi > > @@ -26,6 +26,15 @@ > > cpu-offset = <0x8000>; > > }; > > > > + interrupt-controller at 10440000 { > > Don't we need a node name here (combiner:interrupt-controller at 10440000)? Why? The "combiner:" part is just a label. Actually I think the preferred syntax is &combiner { samsung,combiner-nr = <18>; }; which is much shorter to write, but I did not want to change the style used in the rest of the file. > > + combiner-nr = <18>; > ^^^^^^^^^^^ > nit: tabs instead of space would look better. I fixed that up locally, but I think I sent out the wrong version. > > diff --git a/arch/arm/boot/dts/exynos4412.dtsi b/arch/arm/boot/dts/exynos4412.dtsi > > index d75c047..4cb657e 100644 > > --- a/arch/arm/boot/dts/exynos4412.dtsi > > +++ b/arch/arm/boot/dts/exynos4412.dtsi > > @@ -26,6 +26,15 @@ > > cpu-offset = <0x4000>; > > }; > > > > + interrupt-controller at 10440000 { > > + combiner-nr = <20>; > Same as above (for exynos4212.dtsi). > > > + interrupts = <0 0 0>, <0 1 0>, <0 2 0>, <0 3 0>, > > + <0 4 0>, <0 5 0>, <0 6 0>, <0 7 0>, > > + <0 8 0>, <0 9 0>, <0 10 0>, <0 11 0>, > > + <0 12 0>, <0 13 0>, <0 14 0>, <0 15 0>, > > + <0 107 0>, <0 108 0>>, <0 48 0>, <0 42 0>; > ^^^ > Syntax error. > > We have a combiner node defined in exynos4x12.dtsi. With the bindings > now defined separately in 4212 and 4412 dtsi files, probably the one > in 4x12 could be dropped? I did not see that one, but it seems to have the wrong numbers in the last four interrupt specifiers. I think it would be better to just fix that one and keep using it. Arnd