All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: "Opensource [Anthony Olech]" <anthony.olech.opensource@diasemi.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [NEW DRIVER V4 7/7] DA9058 REGULATOR driver
Date: Mon, 15 Apr 2013 09:35:32 -0700	[thread overview]
Message-ID: <20130415163532.GA24272@roeck-us.net> (raw)
In-Reply-To: <24DF37198A1E704D9811D8F72B87EB514191E103@NB-EX-MBX02.diasemi.com>

On Mon, Apr 15, 2013 at 03:00:58PM +0000, Opensource [Anthony Olech] wrote:
> 
> 
> > -----Original Message-----
> > From: Guenter Roeck [mailto:linux@roeck-us.net]
> > Sent: 12 April 2013 14:32
> > To: Opensource [Anthony Olech]
> > Cc: Mark Brown; Liam Girdwood; Jean Delvare; Randy Dunlap; LKML; David
> > Dajun Chen
> > Subject: Re: [NEW DRIVER V4 7/7] DA9058 REGULATOR driver
> > 
> > On Fri, Apr 12, 2013 at 02:05:28PM +0100, Anthony Olech wrote:
> > > This is the REGULATOR component driver of the Dialog DA9058 PMIC.
> > > This driver is just one component of the whole DA9058 PMIC driver.
> > > It depends on the CORE component driver of the DA9058 MFD.
> > >
> > > There are 6 warnings from scripts/checkpatch.pl, but since it seems to
> > > be complaining about variable names such as min_uV are in CamelCase,
> > > when it is obvious that they are not in CamelCase I have ignored them.
> > >
> > ??? min_uV _is_ CamelCase ???
> > 
> > Ok, maybe it is camelcasE, but you are splitting hairs here.
> 
> it is not me splitting hairs, it is scripts/checkpatch.pl
> 
Maybe you did not understand what I meant. Per your logic,

	MicroVolt is CamelCase
	uVolt is ???
	uV is not CamelCase

By abbreviating CamelCase to camelCase to cC you make it,
in your opinion, acceptable.

If you want to declare CamelCase variables, just do it,
but don't claim that they are not really CamelCase.

Guenter

  reply	other threads:[~2013-04-15 16:35 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-12 13:05 [NEW DRIVER V4 7/7] DA9058 REGULATOR driver Anthony Olech
2013-04-12 13:26 ` Mark Brown
2013-04-16  9:32   ` Opensource [Anthony Olech]
2013-04-12 13:32 ` Guenter Roeck
2013-04-15 15:00   ` Opensource [Anthony Olech]
2013-04-15 16:35     ` Guenter Roeck [this message]
2013-04-15 17:29       ` Opensource [Anthony Olech]
2013-04-15 17:46         ` Guenter Roeck
2013-04-16  9:17           ` Opensource [Anthony Olech]
2013-04-16 13:36             ` Guenter Roeck
2013-04-16 14:07               ` Opensource [Anthony Olech]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130415163532.GA24272@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=anthony.olech.opensource@diasemi.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.