From: chrubis@suse.cz
To: Mike Frysinger <vapier@gentoo.org>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH] getdents01: don't compare first entry to "."
Date: Mon, 15 Apr 2013 19:51:47 +0200 [thread overview]
Message-ID: <20130415175147.GC2405@rei> (raw)
In-Reply-To: <20130405090851.GC18134@rei.Home>
Hi!
> > this test isn't really useful after your change. you've basically validated
> > that the a valid fd and a large enough buffer was passed to the kernel and
> > that's it.
> >
> > you should have it walk the results to try and find an "." and ".." entry.
>
> Yes, that would be even better. Or we can get even more creative and
> create a file or two in the setup and expect them to be in the listing.
FYI: I've just commited a patch that creates file, directory and symlink
and makes sure that these are included in the listing.
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
Precog is a next-generation analytics platform capable of advanced
analytics on semi-structured data. The platform includes APIs for building
apps and a phenomenal toolset for data science. Developers can use
our toolset for easy data analysis & visualization. Get a free account!
http://www2.precog.com/precogplatform/slashdotnewsletter
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
prev parent reply other threads:[~2013-04-15 17:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1365125797-31405-1-git-send-email-gaowanlong@cn.fujitsu.com>
2013-04-05 4:53 ` [LTP] [PATCH] getdents01: don't compare first entry to "." Mike Frysinger
[not found] ` <1365142365-4089-1-git-send-email-gaowanlong@cn.fujitsu.com>
2013-04-05 9:00 ` [LTP] [PATCH V2] getdents01: compare "." or ".." to the first entry chrubis
2013-04-05 9:08 ` [LTP] [PATCH] getdents01: don't compare first entry to "." chrubis
2013-04-15 17:51 ` chrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130415175147.GC2405@rei \
--to=chrubis@suse.cz \
--cc=ltp-list@lists.sourceforge.net \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.