Re: [PATCH] netfilter: rpfilter: skip locally generated bcast, too

[Florian Westphal <fw@strlen.de>]

Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> Hi Florian,
> 
> > diff --git a/net/ipv4/netfilter/ipt_rpfilter.c b/net/ipv4/netfilter/ipt_rpfilter.c
> > index c301300..601abf2 100644
> > --- a/net/ipv4/netfilter/ipt_rpfilter.c
> > +++ b/net/ipv4/netfilter/ipt_rpfilter.c
> > @@ -76,7 +76,7 @@ static bool rpfilter_mt(const struct sk_buff *skb, struct xt_action_param *par)
> >  	info = par->matchinfo;
> >  	invert = info->flags & XT_RPFILTER_INVERT;
> >  
> > -	if (par->in->flags & IFF_LOOPBACK)
> > +	if (skb_dst(skb)) /* locally generated? */
> 
> I'd prefer if this is narrowed down to locally generated traffic in
> the same way we do in nf_conntrack_broadcast.c.

Fair enough, i will change it.