From mboxrd@z Thu Jan 1 00:00:00 1970 From: Egbert Eich Subject: Re: [PATCH 5/7] drm/i915: Add Reenable Timer to turn Hotplug Detection back on (v4) Date: Tue, 16 Apr 2013 22:22:57 +0200 Message-ID: <20130416202257.GE17947@debian> References: <20130416113458.GD17947@debian> <1366112220-7638-1-git-send-email-eich@suse.de> <1366112220-7638-5-git-send-email-eich@suse.de> <20130416180709.GH27612@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.17.9]) by gabe.freedesktop.org (Postfix) with ESMTP id AFF7AE5C36 for ; Tue, 16 Apr 2013 13:23:53 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20130416180709.GH27612@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: Egbert Eich , Daniel Vetter , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Apr 16, 2013 at 08:07:09PM +0200, Daniel Vetter wrote: > On Tue, Apr 16, 2013 at 01:36:58PM +0200, Egbert Eich wrote: > > We disable hoptplug detection when we encounter a hotplug event > > storm. Still hotplug detection is required on some outputs (like > > Display Port). The interrupt storm may be only temporary (on certain > > Dell Laptops for instance it happens at certain charging states of > > the system). Thus we enable it after a certain grace period (2 minutes). > > Should the interrupt storm persist it will be detected immediately > > and it will be disabled again. > > = > > v2: Reordered drm_i915_private: moved hotplug_reenable_timer to hpd sta= te tracker. > > v3: Clarified loop start value, > > Removed superfluous test for Ivybridge and Haswell, > > Restructured loop to avoid deep nesting (all suggested by Ville Syr= j=E4l=E4) > > v4: Fixed two bugs pointed out by Jani Nikula. > > = > > Signed-off-by: Egbert Eich > > Reviewed-by: Jani Nikula > = > I've queued up patches 1-5 of this series, thanks a lot for doing all > this. Wrt bikesheds: checkpatch seemed a bit unhappy about some of them, > but I've decided that I want this more for 3.10 than care about checkpatch > ;-) I've run checkpatch on every patch - here it only complains about lines lon= ger = than 80 characters. Now - if you can prove that my file introduced lines with more than 80 char= acters to a file that had no such lines already we can talk about fixing this ;p Cheers, Egbert.