From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v5 7/7] package: Introduce NOMMU symbol
Date: Tue, 16 Apr 2013 23:30:21 +0200 [thread overview]
Message-ID: <20130416233021.30c4486c@skate> (raw)
In-Reply-To: <1365761909-15305-7-git-send-email-sonic.adi@gmail.com>
Dear Sonic Zhang,
On Fri, 12 Apr 2013 18:18:29 +0800, Sonic Zhang wrote:
> ifeq ($(BR2_BINFMT_FLAT),y)
> TARGET_LDFLAGS += $(if $($(PKG)_FLAT_STACKSIZE),-Wl$(comma)-elf2flt=-s$($(PKG)_FLAT_STACKSIZE))
> +
> +ifneq ($(BR2_USE_MMU), y)
There shouldn't be any space between the comma and the y.
> +TARGET_CFLAGS += -D__NOMMU__
> endif
>
> ifeq ($(BR2_BINFMT_FLAT_SHARED),y)
And you're adding a ifneq condition without adding any endif. Smells
like untested code :)
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2013-04-16 21:30 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-12 10:18 [Buildroot] [PATCH v5 1/7] arch: toolchain: Introduce binary formats BINFMT_* Sonic Zhang
2013-04-12 10:18 ` [Buildroot] [PATCH v5 2/7] arch: Add blackfin CPU choice Sonic Zhang
2013-04-16 18:52 ` Thomas Petazzoni
2013-04-12 10:18 ` [Buildroot] [PATCH v5 3/7] arch: toolchain: Introduce target CPU revision Sonic Zhang
2013-04-16 21:20 ` Thomas Petazzoni
2013-04-12 10:18 ` [Buildroot] [PATCH v5 4/7] arch: toolchain: Introduce binary format FLAT types Sonic Zhang
2013-04-12 10:18 ` [Buildroot] [PATCH v5 5/7] package: Introduce package-specific BINFMT_FLAT options Sonic Zhang
2013-04-16 21:31 ` Thomas Petazzoni
2013-04-12 10:18 ` [Buildroot] [PATCH v5 6/7] arch: toolchain: Install blackfin FDPIC and FLAT libraries in external toolchain makefile Sonic Zhang
2013-04-16 21:29 ` Thomas Petazzoni
2013-04-17 7:50 ` Sonic Zhang
2013-04-17 8:05 ` Thomas Petazzoni
2013-04-17 8:16 ` Sonic Zhang
2013-04-17 8:56 ` Thomas Petazzoni
2013-04-17 9:40 ` Sonic Zhang
2013-04-17 16:41 ` Arnout Vandecappelle
2013-04-18 7:25 ` Thomas Petazzoni
2013-04-12 10:18 ` [Buildroot] [PATCH v5 7/7] package: Introduce NOMMU symbol Sonic Zhang
2013-04-16 21:30 ` Thomas Petazzoni [this message]
2013-04-17 7:27 ` Sonic Zhang
2013-04-16 18:51 ` [Buildroot] [PATCH v5 1/7] arch: toolchain: Introduce binary formats BINFMT_* Thomas Petazzoni
2013-04-17 16:42 ` Arnout Vandecappelle
2013-04-18 7:25 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130416233021.30c4486c@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.