From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] ARM: dts: omap3-beagle-xm: Add USB Host support for Rev Ax/Bx Date: Tue, 16 Apr 2013 17:52:32 -0700 Message-ID: <20130417005232.GV10155@atomide.com> References: <1366029306-1824-1-git-send-email-rogerq@ti.com> <516BF4F3.5060904@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <516BF4F3.5060904-l0cyMroinI0@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Roger Quadros Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-omap@vger.kernel.org KiBSb2dlciBRdWFkcm9zIDxyb2dlcnFAdGkuY29tPiBbMTMwNDE1IDA1OjQ0XToKPiBPbiAwNC8x NS8yMDEzIDAzOjM1IFBNLCBSb2dlciBRdWFkcm9zIHdyb3RlOgo+ID4gUHJvdmlkZSBSRVNFVCBh bmQgUG93ZXIgcmVndWxhdG9ycyBmb3IgdGhlIFVTQiBQSFksCj4gPiB0aGUgVVNCIEhvc3QgcG9y dCBtb2RlIGFuZCB0aGUgUEhZIGRldmljZS4KPiA+IAo+ID4gQWxzbyBwcm92aWRlIHBpbiBtdWx0 aXBsZXhlciBpbmZvcm1hdGlvbiBmb3IgVVNCIGhvc3QKPiA+IHBpbnMuCj4gPiAKPiA+IFRoaXMg d2lsbCBub3Qgd29yayBmb3IgUmV2IEN4IGJvYXJkcyBiZWNhdXNlIG9mIHJldmVyc2VkIGxvZ2lj Cj4gPiBmb3IgVVNCX1BPV0VSX0VuYWJsZS4KPiA+IAo+ID4gQ0M6IEJlbm/DrnQgQ291c3NvbiA8 Yi1jb3Vzc29uQHRpLmNvbT4KPiA+IFNpZ25lZC1vZmYtYnk6IFJvZ2VyIFF1YWRyb3MgPHJvZ2Vy cUB0aS5jb20+Cj4gPiAtLS0KPiA+ICBhcmNoL2FybS9ib290L2R0cy9vbWFwMy1iZWFnbGUteG0u ZHRzIHwgICA2MiArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKPiA+ICAxIGZpbGVz IGNoYW5nZWQsIDYyIGluc2VydGlvbnMoKyksIDAgZGVsZXRpb25zKC0pCj4gPiAKPiA+IGRpZmYg LS1naXQgYS9hcmNoL2FybS9ib290L2R0cy9vbWFwMy1iZWFnbGUteG0uZHRzIGIvYXJjaC9hcm0v Ym9vdC9kdHMvb21hcDMtYmVhZ2xlLXhtLmR0cwo+ID4gaW5kZXggNWEzMTk2NC4uZDM5NGM1MSAx MDA2NDQKPiA+IC0tLSBhL2FyY2gvYXJtL2Jvb3QvZHRzL29tYXAzLWJlYWdsZS14bS5kdHMKPiA+ ICsrKyBiL2FyY2gvYXJtL2Jvb3QvZHRzL29tYXAzLWJlYWdsZS14bS5kdHMKPiA+IEBAIC01Nyw2 ICs1Nyw2MCBAQAo+ID4gIAkJdGksbWNic3AgPSA8Jm1jYnNwMj47Cj4gPiAgCQl0aSxjb2RlYyA9 IDwmdHdsX2F1ZGlvPjsKPiA+ICAJfTsKPiA+ICsKPiA+ICsJLyogSFMgVVNCIFBvcnQgMiBSRVNF VCAqLwo+ID4gKwloc3VzYjJfcmVzZXQ6IGhzdXNiMl9yZXNldF9yZWcgewo+ID4gKwkJY29tcGF0 aWJsZSA9ICJyZWd1bGF0b3ItZml4ZWQiOwo+ID4gKwkJcmVndWxhdG9yLW5hbWUgPSAiaHN1c2Iy X3Jlc2V0IjsKPiA+ICsJCXJlZ3VsYXRvci1taW4tbWljcm92b2x0ID0gPDMzMDAwMDA+Owo+ID4g KwkJcmVndWxhdG9yLW1heC1taWNyb3ZvbHQgPSA8MzMwMDAwMD47Cj4gPiArCQlncGlvID0gPCZn cGlvNSAxOSAwPjsJLyogZ3Bpb18xNDcgKi8KPiA+ICsJCXN0YXJ0dXAtZGVsYXktdXMgPSA8NzAw MDA+Owo+ID4gKwkJZW5hYmxlLWFjdGl2ZS1oaWdoOwo+ID4gKwl9Owo+ID4gKwo+ID4gKwkvKiBI UyBVU0IgUG9ydCAyIFBvd2VyICovCj4gPiArCWhzdXNiMl9wb3dlcjogaHN1c2IyX3Bvd2VyX3Jl ZyB7Cj4gPiArCQljb21wYXRpYmxlID0gInJlZ3VsYXRvci1maXhlZCI7Cj4gPiArCQlyZWd1bGF0 b3ItbmFtZSA9ICJoc3VzYjJfdmJ1cyI7Cj4gPiArCQlyZWd1bGF0b3ItbWluLW1pY3Jvdm9sdCA9 IDwzMzAwMDAwPjsKPiA+ICsJCXJlZ3VsYXRvci1tYXgtbWljcm92b2x0ID0gPDMzMDAwMDA+Owo+ ID4gKwkJZ3BpbyA9IDwmdHdsX2dwaW8gMTggMD47CS8qIEdQSU8gTEVEQSAqLwo+ID4gKwkJc3Rh cnR1cC1kZWxheS11cyA9IDw3MDAwMD47Cj4gPiArCQllbmFibGUtYWN0aXZlLWhpZ2g7CS8qIEZJ WE1FOiBhY3RpdmUtbG93IGZvciBSZXYuIEMgKi8KPiAKPiBCZW5vaXQgJiBUb255LAo+IAo+IEFu eSBpZGVhcyBob3cgdG8gdGFja2xlIHRoZSByZXZlcnNlZCBsb2dpYyBmb3IgUmV2LiBDIGJvYXJk cz8KClNvdW5kcyBsaWtlIHdlIG5lZWQgYSBzaGFyZWQgb21hcDMtYmVhZ2UuZHRzaSwgdGhlbiBv bWFwMy1iZWFnbGUteG0uZHRzCmFuZCBvbWFwMy1iZWFnbGUtcmV2LWMuZHRzLiBUaGVuIHhtIGFu ZCByZXYtYyBjYW4gYm90aCBpbmNsdWRlIHRoZQpjb21tb24gLmR0c2kuCgpSZWdhcmRzLAoKVG9u eQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkZXZpY2V0 cmVlLWRpc2N1c3MgbWFpbGluZyBsaXN0CmRldmljZXRyZWUtZGlzY3Vzc0BsaXN0cy5vemxhYnMu b3JnCmh0dHBzOi8vbGlzdHMub3psYWJzLm9yZy9saXN0aW5mby9kZXZpY2V0cmVlLWRpc2N1c3MK From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Tue, 16 Apr 2013 17:52:32 -0700 Subject: [PATCH] ARM: dts: omap3-beagle-xm: Add USB Host support for Rev Ax/Bx In-Reply-To: <516BF4F3.5060904@ti.com> References: <1366029306-1824-1-git-send-email-rogerq@ti.com> <516BF4F3.5060904@ti.com> Message-ID: <20130417005232.GV10155@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Roger Quadros [130415 05:44]: > On 04/15/2013 03:35 PM, Roger Quadros wrote: > > Provide RESET and Power regulators for the USB PHY, > > the USB Host port mode and the PHY device. > > > > Also provide pin multiplexer information for USB host > > pins. > > > > This will not work for Rev Cx boards because of reversed logic > > for USB_POWER_Enable. > > > > CC: Beno?t Cousson > > Signed-off-by: Roger Quadros > > --- > > arch/arm/boot/dts/omap3-beagle-xm.dts | 62 +++++++++++++++++++++++++++++++++ > > 1 files changed, 62 insertions(+), 0 deletions(-) > > > > diff --git a/arch/arm/boot/dts/omap3-beagle-xm.dts b/arch/arm/boot/dts/omap3-beagle-xm.dts > > index 5a31964..d394c51 100644 > > --- a/arch/arm/boot/dts/omap3-beagle-xm.dts > > +++ b/arch/arm/boot/dts/omap3-beagle-xm.dts > > @@ -57,6 +57,60 @@ > > ti,mcbsp = <&mcbsp2>; > > ti,codec = <&twl_audio>; > > }; > > + > > + /* HS USB Port 2 RESET */ > > + hsusb2_reset: hsusb2_reset_reg { > > + compatible = "regulator-fixed"; > > + regulator-name = "hsusb2_reset"; > > + regulator-min-microvolt = <3300000>; > > + regulator-max-microvolt = <3300000>; > > + gpio = <&gpio5 19 0>; /* gpio_147 */ > > + startup-delay-us = <70000>; > > + enable-active-high; > > + }; > > + > > + /* HS USB Port 2 Power */ > > + hsusb2_power: hsusb2_power_reg { > > + compatible = "regulator-fixed"; > > + regulator-name = "hsusb2_vbus"; > > + regulator-min-microvolt = <3300000>; > > + regulator-max-microvolt = <3300000>; > > + gpio = <&twl_gpio 18 0>; /* GPIO LEDA */ > > + startup-delay-us = <70000>; > > + enable-active-high; /* FIXME: active-low for Rev. C */ > > Benoit & Tony, > > Any ideas how to tackle the reversed logic for Rev. C boards? Sounds like we need a shared omap3-beage.dtsi, then omap3-beagle-xm.dts and omap3-beagle-rev-c.dts. Then xm and rev-c can both include the common .dtsi. Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755760Ab3DQAwi (ORCPT ); Tue, 16 Apr 2013 20:52:38 -0400 Received: from mho-03-ewr.mailhop.org ([204.13.248.66]:22556 "EHLO mho-01-ewr.mailhop.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754273Ab3DQAwh (ORCPT ); Tue, 16 Apr 2013 20:52:37 -0400 X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 50.131.214.131 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX1/7Ln7ORT83SEaTl2zaO65c Date: Tue, 16 Apr 2013 17:52:32 -0700 From: Tony Lindgren To: Roger Quadros Cc: b-cousson@ti.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: dts: omap3-beagle-xm: Add USB Host support for Rev Ax/Bx Message-ID: <20130417005232.GV10155@atomide.com> References: <1366029306-1824-1-git-send-email-rogerq@ti.com> <516BF4F3.5060904@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <516BF4F3.5060904@ti.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Roger Quadros [130415 05:44]: > On 04/15/2013 03:35 PM, Roger Quadros wrote: > > Provide RESET and Power regulators for the USB PHY, > > the USB Host port mode and the PHY device. > > > > Also provide pin multiplexer information for USB host > > pins. > > > > This will not work for Rev Cx boards because of reversed logic > > for USB_POWER_Enable. > > > > CC: Benoît Cousson > > Signed-off-by: Roger Quadros > > --- > > arch/arm/boot/dts/omap3-beagle-xm.dts | 62 +++++++++++++++++++++++++++++++++ > > 1 files changed, 62 insertions(+), 0 deletions(-) > > > > diff --git a/arch/arm/boot/dts/omap3-beagle-xm.dts b/arch/arm/boot/dts/omap3-beagle-xm.dts > > index 5a31964..d394c51 100644 > > --- a/arch/arm/boot/dts/omap3-beagle-xm.dts > > +++ b/arch/arm/boot/dts/omap3-beagle-xm.dts > > @@ -57,6 +57,60 @@ > > ti,mcbsp = <&mcbsp2>; > > ti,codec = <&twl_audio>; > > }; > > + > > + /* HS USB Port 2 RESET */ > > + hsusb2_reset: hsusb2_reset_reg { > > + compatible = "regulator-fixed"; > > + regulator-name = "hsusb2_reset"; > > + regulator-min-microvolt = <3300000>; > > + regulator-max-microvolt = <3300000>; > > + gpio = <&gpio5 19 0>; /* gpio_147 */ > > + startup-delay-us = <70000>; > > + enable-active-high; > > + }; > > + > > + /* HS USB Port 2 Power */ > > + hsusb2_power: hsusb2_power_reg { > > + compatible = "regulator-fixed"; > > + regulator-name = "hsusb2_vbus"; > > + regulator-min-microvolt = <3300000>; > > + regulator-max-microvolt = <3300000>; > > + gpio = <&twl_gpio 18 0>; /* GPIO LEDA */ > > + startup-delay-us = <70000>; > > + enable-active-high; /* FIXME: active-low for Rev. C */ > > Benoit & Tony, > > Any ideas how to tackle the reversed logic for Rev. C boards? Sounds like we need a shared omap3-beage.dtsi, then omap3-beagle-xm.dts and omap3-beagle-rev-c.dts. Then xm and rev-c can both include the common .dtsi. Regards, Tony