From: Ingo Molnar <mingo@kernel.org>
To: Waiman Long <Waiman.Long@hp.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
David Howells <dhowells@redhat.com>,
Dave Jones <davej@redhat.com>,
Clark Williams <williams@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org, x86@kernel.org,
linux-arch@vger.kernel.org, "Chandramouleeswaran,
Aswin" <aswin@hp.com>, Davidlohr Bueso <davidlohr.bueso@hp.com>,
"Norton, Scott J" <scott.norton@hp.com>,
Rik van Riel <riel@redhat.com>
Subject: Re: [PATCH v3 5/5] mutex: Move mutex spinning code from sched/core.c back to mutex.c
Date: Wed, 17 Apr 2013 09:18:27 +0200 [thread overview]
Message-ID: <20130417071827.GB21051@gmail.com> (raw)
In-Reply-To: <1366172891-7729-6-git-send-email-Waiman.Long@hp.com>
* Waiman Long <Waiman.Long@hp.com> wrote:
> As mentioned by Ingo, the SCHED_FEAT_OWNER_SPIN scheduler feature
> bit was really just an early hack to make with/without mutex-spinning
> testable. So it is no longer necessary.
>
> This patch removes the SCHED_FEAT_OWNER_SPIN feature bit and move the
> mutex spinning code from kernel/sched/core.c back to kernel/mutex.c
> which is where they should belong.
>
> Signed-off-by: Waiman Long <Waiman.Long@hp.com>
> ---
> include/linux/sched.h | 4 ---
> kernel/mutex.c | 62 ++++++++++++++++++++++++++++++++++++++++++++++
> kernel/sched/core.c | 63 -----------------------------------------------
> kernel/sched/features.h | 7 -----
> 4 files changed, 62 insertions(+), 74 deletions(-)
Please move this patch first in the series - so that later, functional patches are
easier to revert, should the need arise. When possible we sort patches by risk:
low risk ones first, riskier come later.
Thanks,
Ingo
next prev parent reply other threads:[~2013-04-17 7:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-17 4:28 [PATCH v3 0/5] mutex: Improve mutex performance by doing less atomic-ops & better spinning Waiman Long
2013-04-17 4:28 ` [PATCH v3 1/5] mutex: Make more scalable by doing less atomic operations Waiman Long
2013-04-17 4:28 ` [PATCH v3 2/5] mutex: Queue mutex spinners with MCS lock to reduce cacheline contention Waiman Long
2013-04-17 4:28 ` [PATCH v3 optional 3/5] mutex: back out architecture specific check for negative mutex count Waiman Long
2013-04-17 4:28 ` [PATCH v3 4/5] mutex: Remove new typedefs introduced in patch 2 Waiman Long
2013-04-17 7:17 ` Ingo Molnar
2013-04-17 4:28 ` [PATCH v3 5/5] mutex: Move mutex spinning code from sched/core.c back to mutex.c Waiman Long
2013-04-17 7:18 ` Ingo Molnar [this message]
2013-04-17 19:28 ` Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130417071827.GB21051@gmail.com \
--to=mingo@kernel.org \
--cc=Waiman.Long@hp.com \
--cc=aswin@hp.com \
--cc=davej@redhat.com \
--cc=davidlohr.bueso@hp.com \
--cc=dhowells@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=scott.norton@hp.com \
--cc=tglx@linutronix.de \
--cc=williams@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.