From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56549) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USSPd-0004Ok-5E for qemu-devel@nongnu.org; Wed, 17 Apr 2013 09:28:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1USSPb-0000mc-Uf for qemu-devel@nongnu.org; Wed, 17 Apr 2013 09:28:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:8426) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USSPb-0000mM-L8 for qemu-devel@nongnu.org; Wed, 17 Apr 2013 09:28:35 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3HDSZH7016184 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 17 Apr 2013 09:28:35 -0400 Date: Wed, 17 Apr 2013 09:28:33 -0400 From: Luiz Capitulino Message-ID: <20130417092833.73108a00@redhat.com> In-Reply-To: <87ppxvosv7.fsf@blackfin.pond.sub.org> References: <1366091252-16802-1-git-send-email-akong@redhat.com> <87ppxvosv7.fsf@blackfin.pond.sub.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] monitor: fix the wrong order of releasing keys List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Amos Kong , qemu-devel@nongnu.org On Tue, 16 Apr 2013 09:08:12 +0200 Markus Armbruster wrote: > Amos Kong writes: > > > (qemu) sendkey ctrl_r-scroll_lock-scroll_lock > > > > Executing this command could not let Windows guest panic, it caused by > > "could not"? You can use Windows' editor to setup Windows to panic on a key sequence, and that feature (or Windows itself) is sensible to the key release ordering. This caught a problem with the sendkey command conversion to the qapi: we changed the release key ordering from last to first to first to last. > > the wrong order of releasing keys. This problem was introduced by > > commit e4c8f004c55d9da3eae3e14df740238bf805b5d6. > > > > The right release order should be starting from last item. > > > > Signed-off-by: Amos Kong > > --- > > ui/input.c | 8 +++----- > > 1 files changed, 3 insertions(+), 5 deletions(-) > > > > diff --git a/ui/input.c b/ui/input.c > > index 9abef0c..ecfeb43 100644 > > --- a/ui/input.c > > +++ b/ui/input.c > > @@ -234,13 +234,11 @@ static void free_keycodes(void) > > > > static void release_keys(void *opaque) > > { > > - int i; > > - > > - for (i = 0; i < keycodes_size; i++) { > > - if (keycodes[i] & 0x80) { > > + while (keycodes_size > 0) { > > + if (keycodes[--keycodes_size] & 0x80) { > > kbd_put_keycode(0xe0); > > } > > - kbd_put_keycode(keycodes[i]| 0x80); > > + kbd_put_keycode(keycodes[keycodes_size] | 0x80); > > } > > > > free_keycodes(); >