Re: Compilation breakage on drivers/media due to OF patches - was: Re: [PATCH] DT: export of_get_next_parent() for use by modules: fix modular V4L2

[Mauro Carvalho Chehab <mchehab@redhat.com>]

Em Wed, 17 Apr 2013 16:08:43 +0100
Grant Likely <grant.likely@secretlab.ca> escreveu:

> On Wed, 17 Apr 2013 11:53:57 -0300, Mauro Carvalho Chehab <mchehab@redhat.com> wrote:
> > Hi Grant/Rob,
> > 
> > Our tree is currently _broken_ with OT, because of the lack of 
> > exporting of_get_next_parent. The developer that submitted the patches 
> > that added V4L2 OF support forgot to test to compilation with MODULES
> > support enabled.
> > 
> > So, we're now having:
> > 	ERROR: "of_get_next_parent" [drivers/media/v4l2-core/videodev.ko] undefined!
> > 
> > if compiled with OF enabled and media as module.
> > 
> > As those patches were applied at my master branch and there are lots of
> > other patches on the top of the patches that added V4L2 OF support, 
> > I prefer to avoid reverting those patches. 
> > 
> > On the other hand, I can't send the patches upstream next week (assuming 
> > that -rc7 is the final one), without having this patch applying before 
> > the media tree.
> 
> The fix needs to be applied to your tree then. Go ahead and apply it with my ack:
> 
> Acked-by: Grant Likely <grant.likely@linaro.org>

Thank you!

> It is no good to apply it to the devicetree -next branch because that
> will still leave your branch broken, even if device tree gets merged
> first.

True.

Thanks,
Mauro