From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Wed, 17 Apr 2013 18:00:33 +0200 (CEST) Received: from mail-wg0-f51.google.com ([74.125.82.51]:46739 "EHLO mail-wg0-f51.google.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S6816285Ab3DQQAbgIMg3 (ORCPT ); Wed, 17 Apr 2013 18:00:31 +0200 Received: by mail-wg0-f51.google.com with SMTP id b13so1752242wgh.6 for ; Wed, 17 Apr 2013 09:00:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:sender:from:subject:to:cc:in-reply-to:references:date :message-id:x-gm-message-state; bh=t3oVUqRhOYNqsB3cPHxP1nheOSmp9VlTNn0DiwRFyxg=; b=GKCKSBLJ3mvAAIMqtF1L7JjH5E47u9Jc9y/J6elPTzZbwZTcKluXzKoKofyJyfKA4h O9XFB4gMsKWJLHjHINdFiQ07puHukJvtjs0Gn9wl1nfKXyhRI7QUDA29ekN3BPvCilE1 uXzwxgDPfCokI+NoYIECCSOzeb7aityf14K3n3I2WcK9GbMXpS/nrMtUF7FlIzp2jMJg jY3tS4heh+Cm1NSnuYe4h7sUR7IhjVCUbpJShio7DhpYDu/jMZHT6cHIx8XTpj2q9uYZ DM51O5GEyohF8bNZCPl1dKX1Yiu/+dVw/h2MXKpl0I6pkVl3yGgIiRjJQRA8hD9DFBGe JdWA== X-Received: by 10.194.89.169 with SMTP id bp9mr12437072wjb.57.1366214422980; Wed, 17 Apr 2013 09:00:22 -0700 (PDT) Received: from localhost (host31-54-169-16.range31-54.btcentralplus.com. [31.54.169.16]) by mx.google.com with ESMTPS id du2sm26381874wib.0.2013.04.17.09.00.16 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 17 Apr 2013 09:00:18 -0700 (PDT) Received: by localhost (Postfix, from userid 1000) id 777453E2B73; Wed, 17 Apr 2013 17:00:15 +0100 (BST) From: Grant Likely Subject: Re: [PATCH v7 1/3] of/pci: Unify pci_process_bridge_OF_ranges from Microblaze and PowerPC To: Andrew Murray , "linux-mips@linux-mips.org" , "linuxppc-dev@lists.ozlabs.org" Cc: "siva.kallam@samsung.com" , "linux-pci@vger.kernel.org" , "linus.walleij@linaro.org" , "thierry.reding@avionic-design.de" , Liviu Dudau , "paulus@samba.org" , "linux-samsung-soc@vger.kernel.org" , "linux@arm.linux.org.uk" , "jg1.han@samsung.com" , "jgunthorpe@obsidianresearch.com" , "thomas.abraham@linaro.org" , "benh@kernel.crashing.org" , "arnd@arndb.de" , "devicetree-discuss@lists.ozlabs.org" , "rob.herring@calxeda.com" , "kgene.kim@samsung.com" , "bhelgaas@google.com" , "linux-arm-kernel@lists.infradead.org" , "thomas.petazzoni@free-electrons.com" , "monstr@monstr.eu" , "linux-kernel@vger.kernel.org" , "suren.reddy@samsung.com" In-Reply-To: <20130416103005.GB12726@arm.com> References: <1366107508-12672-1-git-send-email-Andrew.Murray@arm.com> <1366107508-12672-2-git-send-email-Andrew.Murray@arm.com> <20130416103005.GB12726@arm.com> Date: Wed, 17 Apr 2013 17:00:15 +0100 Message-Id: <20130417160015.777453E2B73@localhost> X-Gm-Message-State: ALoCoQk/n561b6ooXvXN5yAAuYnvc61gzL5wVa+iKp8PqjjlFEQHUzmpBoy5fxJZ1MubAuxiQEYk Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 36252 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: grant.likely@secretlab.ca Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On Tue, 16 Apr 2013 11:30:06 +0100, Andrew Murray wrote: > On Tue, Apr 16, 2013 at 11:18:26AM +0100, Andrew Murray wrote: > > The pci_process_bridge_OF_ranges function, used to parse the "ranges" > > property of a PCI host device, is found in both Microblaze and PowerPC > > architectures. These implementations are nearly identical. This patch > > moves this common code to a common place. > > > > Signed-off-by: Andrew Murray > > Signed-off-by: Liviu Dudau > > Reviewed-by: Rob Herring > > Tested-by: Thomas Petazzoni > > Tested-by: Linus Walleij > > Acked-by: Michal Simek > > --- > > arch/microblaze/include/asm/pci-bridge.h | 5 +- > > arch/microblaze/pci/pci-common.c | 192 ---------------------------- > > arch/powerpc/include/asm/pci-bridge.h | 5 +- > > arch/powerpc/kernel/pci-common.c | 192 ---------------------------- > > Is there anyone on linuxppc-dev/linux-mips that can help test this patchset? > > I've tested that it builds on powerpc with a variety of configs (some which > include fsl_pci.c implementation). Though I don't have hardware to verify that > it works. > > I haven't tested this builds or runs on MIPS. > > You shouldn't see any difference in behaviour or new warnings and PCI devices > should continue to operate as before. I've got through a line-by-line comparison between powerpc, microblaze, and then new code. The differences are purely cosmetic, so I have absolutely no concerns about this patch. I've applied it to my tree. g. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Likely Subject: Re: [PATCH v7 1/3] of/pci: Unify pci_process_bridge_OF_ranges from Microblaze and PowerPC Date: Wed, 17 Apr 2013 17:00:15 +0100 Message-ID: <20130417160015.777453E2B73@localhost> References: <1366107508-12672-1-git-send-email-Andrew.Murray@arm.com> <1366107508-12672-2-git-send-email-Andrew.Murray@arm.com> <20130416103005.GB12726@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20130416103005.GB12726@arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Andrew Murray , "linux-mips@linux-mips.org" , "linuxppc-dev@lists.ozlabs.org" Cc: "siva.kallam@samsung.com" , "linux-pci@vger.kernel.org" , "linus.walleij@linaro.org" , "thierry.reding@avionic-design.de" , Liviu Dudau , "paulus@samba.org" , "linux-samsung-soc@vger.kernel.org" , "linux@arm.linux.org.uk" , "jg1.han@samsung.com" , "jgunthorpe@obsidianresearch.com" , "thomas.abraham@linaro.org" , "benh@kernel.crashing.org" , "arnd@arndb.de" , "devicetree-discuss@lists.ozlabs.org" , "rob.herring@calxeda.com" , "kgene.kim@samsung.com" , bhelgaas List-Id: linux-samsung-soc@vger.kernel.org On Tue, 16 Apr 2013 11:30:06 +0100, Andrew Murray wrote: > On Tue, Apr 16, 2013 at 11:18:26AM +0100, Andrew Murray wrote: > > The pci_process_bridge_OF_ranges function, used to parse the "ranges" > > property of a PCI host device, is found in both Microblaze and PowerPC > > architectures. These implementations are nearly identical. This patch > > moves this common code to a common place. > > > > Signed-off-by: Andrew Murray > > Signed-off-by: Liviu Dudau > > Reviewed-by: Rob Herring > > Tested-by: Thomas Petazzoni > > Tested-by: Linus Walleij > > Acked-by: Michal Simek > > --- > > arch/microblaze/include/asm/pci-bridge.h | 5 +- > > arch/microblaze/pci/pci-common.c | 192 ---------------------------- > > arch/powerpc/include/asm/pci-bridge.h | 5 +- > > arch/powerpc/kernel/pci-common.c | 192 ---------------------------- > > Is there anyone on linuxppc-dev/linux-mips that can help test this patchset? > > I've tested that it builds on powerpc with a variety of configs (some which > include fsl_pci.c implementation). Though I don't have hardware to verify that > it works. > > I haven't tested this builds or runs on MIPS. > > You shouldn't see any difference in behaviour or new warnings and PCI devices > should continue to operate as before. I've got through a line-by-line comparison between powerpc, microblaze, and then new code. The differences are purely cosmetic, so I have absolutely no concerns about this patch. I've applied it to my tree. g. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-x236.google.com (mail-wi0-x236.google.com [IPv6:2a00:1450:400c:c05::236]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id B62AB2C0153 for ; Thu, 18 Apr 2013 02:00:30 +1000 (EST) Received: by mail-wi0-f182.google.com with SMTP id m6so1722064wiv.3 for ; Wed, 17 Apr 2013 09:00:26 -0700 (PDT) Sender: Grant Likely From: Grant Likely Subject: Re: [PATCH v7 1/3] of/pci: Unify pci_process_bridge_OF_ranges from Microblaze and PowerPC To: Andrew Murray , "linux-mips@linux-mips.org" , "linuxppc-dev@lists.ozlabs.org" In-Reply-To: <20130416103005.GB12726@arm.com> References: <1366107508-12672-1-git-send-email-Andrew.Murray@arm.com> <1366107508-12672-2-git-send-email-Andrew.Murray@arm.com> <20130416103005.GB12726@arm.com> Date: Wed, 17 Apr 2013 17:00:15 +0100 Message-Id: <20130417160015.777453E2B73@localhost> Cc: "siva.kallam@samsung.com" , "linux-pci@vger.kernel.org" , "linus.walleij@linaro.org" , "thierry.reding@avionic-design.de" , Liviu Dudau , "paulus@samba.org" , "linux-samsung-soc@vger.kernel.org" , "linux@arm.linux.org.uk" , "jg1.han@samsung.com" , "jgunthorpe@obsidianresearch.com" , "thomas.abraham@linaro.org" , "arnd@arndb.de" , "devicetree-discuss@lists.ozlabs.org" , "rob.herring@calxeda.com" , "kgene.kim@samsung.com" , "bhelgaas@google.com" , "linux-arm-kernel@lists.infradead.org" , "thomas.petazzoni@free-electrons.com" , "monstr@monstr.eu" , "linux-kernel@vger.kernel.org" , "suren.reddy@samsung.com" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, 16 Apr 2013 11:30:06 +0100, Andrew Murray wrote: > On Tue, Apr 16, 2013 at 11:18:26AM +0100, Andrew Murray wrote: > > The pci_process_bridge_OF_ranges function, used to parse the "ranges" > > property of a PCI host device, is found in both Microblaze and PowerPC > > architectures. These implementations are nearly identical. This patch > > moves this common code to a common place. > > > > Signed-off-by: Andrew Murray > > Signed-off-by: Liviu Dudau > > Reviewed-by: Rob Herring > > Tested-by: Thomas Petazzoni > > Tested-by: Linus Walleij > > Acked-by: Michal Simek > > --- > > arch/microblaze/include/asm/pci-bridge.h | 5 +- > > arch/microblaze/pci/pci-common.c | 192 ---------------------------- > > arch/powerpc/include/asm/pci-bridge.h | 5 +- > > arch/powerpc/kernel/pci-common.c | 192 ---------------------------- > > Is there anyone on linuxppc-dev/linux-mips that can help test this patchset? > > I've tested that it builds on powerpc with a variety of configs (some which > include fsl_pci.c implementation). Though I don't have hardware to verify that > it works. > > I haven't tested this builds or runs on MIPS. > > You shouldn't see any difference in behaviour or new warnings and PCI devices > should continue to operate as before. I've got through a line-by-line comparison between powerpc, microblaze, and then new code. The differences are purely cosmetic, so I have absolutely no concerns about this patch. I've applied it to my tree. g. From mboxrd@z Thu Jan 1 00:00:00 1970 From: grant.likely@secretlab.ca (Grant Likely) Date: Wed, 17 Apr 2013 17:00:15 +0100 Subject: [PATCH v7 1/3] of/pci: Unify pci_process_bridge_OF_ranges from Microblaze and PowerPC In-Reply-To: <20130416103005.GB12726@arm.com> References: <1366107508-12672-1-git-send-email-Andrew.Murray@arm.com> <1366107508-12672-2-git-send-email-Andrew.Murray@arm.com> <20130416103005.GB12726@arm.com> Message-ID: <20130417160015.777453E2B73@localhost> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, 16 Apr 2013 11:30:06 +0100, Andrew Murray wrote: > On Tue, Apr 16, 2013 at 11:18:26AM +0100, Andrew Murray wrote: > > The pci_process_bridge_OF_ranges function, used to parse the "ranges" > > property of a PCI host device, is found in both Microblaze and PowerPC > > architectures. These implementations are nearly identical. This patch > > moves this common code to a common place. > > > > Signed-off-by: Andrew Murray > > Signed-off-by: Liviu Dudau > > Reviewed-by: Rob Herring > > Tested-by: Thomas Petazzoni > > Tested-by: Linus Walleij > > Acked-by: Michal Simek > > --- > > arch/microblaze/include/asm/pci-bridge.h | 5 +- > > arch/microblaze/pci/pci-common.c | 192 ---------------------------- > > arch/powerpc/include/asm/pci-bridge.h | 5 +- > > arch/powerpc/kernel/pci-common.c | 192 ---------------------------- > > Is there anyone on linuxppc-dev/linux-mips that can help test this patchset? > > I've tested that it builds on powerpc with a variety of configs (some which > include fsl_pci.c implementation). Though I don't have hardware to verify that > it works. > > I haven't tested this builds or runs on MIPS. > > You shouldn't see any difference in behaviour or new warnings and PCI devices > should continue to operate as before. I've got through a line-by-line comparison between powerpc, microblaze, and then new code. The differences are purely cosmetic, so I have absolutely no concerns about this patch. I've applied it to my tree. g.