From: Mark Brown <broonie@kernel.org>
To: Anthony Olech <anthony.olech.opensource@diasemi.com>
Cc: Liam Girdwood <lrg@ti.com>, Guenter Roeck <linux@roeck-us.net>,
Jean Delvare <khali@linux-fr.org>,
Randy Dunlap <rdunlap@xenotime.net>,
LKML <linux-kernel@vger.kernel.org>,
David Dajun Chen <david.chen@diasemi.com>
Subject: Re: [NEW DRIVER V5 7/7] drivers/regulator: DA9058 REGULATOR driver
Date: Wed, 17 Apr 2013 20:24:40 +0100 [thread overview]
Message-ID: <20130417192440.GC19873@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <201304171638.r3HGc3Qv023842@latitude>
On Wed, Apr 17, 2013 at 05:33:37PM +0100, Anthony Olech wrote:
> + reg->init.constraints.name = rpdata->regulator_name;
> + reg->init.constraints.min_uv = rpdata->min_uv;
> + reg->init.constraints.max_uv = rpdata->max_uv;
> + reg->init.constraints.valid_ops_mask = rpdata->valid_ops_mask;
> + reg->init.constraints.valid_modes_mask = rpdata->valid_modes_mask;
> + reg->init.constraints.boot_on = rpdata->boot_on;
> + reg->init.constraints.always_on = rpdata->always_on;
> + reg->init.num_consumer_supplies = rpdata->num_consumer_supplies;
> + reg->init.consumer_supplies = rpdata->consumer_supplies;
Just embed a regulator_init_data or pointer to one in the platform data,
the driver should not need to care about the contents - think what
happens if we add new features to the API...
prev parent reply other threads:[~2013-04-17 19:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-17 16:33 [NEW DRIVER V5 7/7] drivers/regulator: DA9058 REGULATOR driver Anthony Olech
2013-04-17 19:24 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130417192440.GC19873@opensource.wolfsonmicro.com \
--to=broonie@kernel.org \
--cc=anthony.olech.opensource@diasemi.com \
--cc=david.chen@diasemi.com \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lrg@ti.com \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.