All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Lindner <lindner_marek@yahoo.de>
To: The list for a Better Approach To Mobile Ad-hoc Networking
	<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCHv2] batman-adv: change VID semantic in the BLA code
Date: Thu, 18 Apr 2013 00:37:13 +0800	[thread overview]
Message-ID: <201304180037.13749.lindner_marek@yahoo.de> (raw)
In-Reply-To: <1365412636-26039-1-git-send-email-ordex@autistici.org>

On Monday, April 08, 2013 17:17:16 Antonio Quartulli wrote:
> @@ -307,7 +307,7 @@ static void batadv_bla_send_claim(struct batadv_priv
> *bat_priv, uint8_t *mac, */
>                 memcpy(ethhdr->h_source, mac, ETH_ALEN);
>                 batadv_dbg(BATADV_DBG_BLA, bat_priv,
> -                          "bla_send_claim(): CLAIM %pM on vid %d\n", mac,
> vid); +                          "bla_send_claim(): CLAIM %pM on vid
> %u\n", mac, vid); break;
>         case BATADV_CLAIM_TYPE_UNCLAIM:
>                 /* unclaim frame
> @@ -315,7 +315,7 @@ static void batadv_bla_send_claim(struct batadv_priv
> *bat_priv, uint8_t *mac, */
>                 memcpy(hw_src, mac, ETH_ALEN);
>                 batadv_dbg(BATADV_DBG_BLA, bat_priv,
> -                          "bla_send_claim(): UNCLAIM %pM on vid %d\n",
> mac, +                          "bla_send_claim(): UNCLAIM %pM on vid
> %u\n", mac, vid);
>                 break;
>         case BATADV_CLAIM_TYPE_ANNOUNCE:
> @@ -324,7 +324,7 @@ static void batadv_bla_send_claim(struct batadv_priv
> *bat_priv, uint8_t *mac, */
>                 memcpy(hw_src, mac, ETH_ALEN);
>                 batadv_dbg(BATADV_DBG_BLA, bat_priv,
> -                          "bla_send_claim(): ANNOUNCE of %pM on vid %d\n",
> +                          "bla_send_claim(): ANNOUNCE of %pM on vid %u\n",

It should be %hu instead of %u for unsigned short.

Please make sure the printed vid does not contain the BATADV_VLAN_HAS_TAG 
mixed with the real vid.

Cheers,
Marek

      parent reply	other threads:[~2013-04-17 16:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-08  9:17 [B.A.T.M.A.N.] [PATCHv2] batman-adv: change VID semantic in the BLA code Antonio Quartulli
2013-04-17 16:32 ` Simon Wunderlich
2013-04-17 16:37 ` Marek Lindner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201304180037.13749.lindner_marek@yahoo.de \
    --to=lindner_marek@yahoo.de \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.