From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:42916)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1USpSV-0000EW-3Q
	for qemu-devel@nongnu.org; Thu, 18 Apr 2013 10:05:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1USpSS-0007x6-G9
	for qemu-devel@nongnu.org; Thu, 18 Apr 2013 10:05:07 -0400
Received: from mx1.redhat.com ([209.132.183.28]:15259)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1USpSS-0007w1-7c
	for qemu-devel@nongnu.org; Thu, 18 Apr 2013 10:05:04 -0400
Date: Thu, 18 Apr 2013 16:06:11 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20130418130611.GA20196@redhat.com>
References: <1366240040-10730-1-git-send-email-mrhines@linux.vnet.ibm.com>
	<1366240040-10730-9-git-send-email-mrhines@linux.vnet.ibm.com>
	<20130418075828.GA15869@redhat.com>
	<516FFC58.8050303@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <516FFC58.8050303@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael R. Hines" <mrhines@linux.vnet.ibm.com>
Cc: aliguori@us.ibm.com, quintela@redhat.com, qemu-devel@nongnu.org, owasserm@redhat.com, abali@us.ibm.com, mrhines@us.ibm.com, gokul@us.ibm.com, pbonzini@redhat.com

On Thu, Apr 18, 2013 at 09:59:52AM -0400, Michael R. Hines wrote:
> On 04/18/2013 03:58 AM, Michael S. Tsirkin wrote:
> >The following comment applies to all of this code:
> >
> >On Wed, Apr 17, 2013 at 07:07:17PM -0400, mrhines@linux.vnet.ibm.com wrote:
> >>diff --git a/migration-rdma.c b/migration-rdma.c
> >>new file mode 100644
> >>index 0000000..1dff06f
> >>--- /dev/null
> >>+++ b/migration-rdma.c
> >>@@ -0,0 +1,2667 @@
> >>+/*
> >>+ *  Copyright (C) 2013 Michael R. Hines <mrhines@us.ibm.com>
> >>+ *  Copyright (C) 2010 Jiuxing Liu <jl@us.ibm.com>
> >By the way do you both really hold copyrights on this code?
> >It's not assigned to IBM?
> >If the later it should say:
> >	Copyright IBM
> >	Author: Michael R. Hines
> >Or some such.
> 
> Acknowledged.
> 
> >>+ *
> >>+ *  RDMA protocol and interfaces
> >>+ *
> >>+ *  This program is free software; you can redistribute it and/or modify
> >>+ *  it under the terms of the GNU General Public License as published by
> >>+ *  the Free Software Foundation; under version 2 of the License.
> >
> >We prefer 2 or later for new code.
> 
> Doesn't it say version 2 already?

version 2 != 'version 2 or later'. See COPYING at the top level in qemu.

> >I'm guessing you need approval from Jiuxing Liu for this,
> >pls make him ack license change.
> 
> He approves. He doesn't work for IBM anymore.

Does he approve version 2 or version 2 or later?