From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH 0/4] drm/edid: Recognize 60Hz and 59.94Hz CEA modes
Date: Thu, 18 Apr 2013 18:31:30 +0300
Message-ID: <20130418153130.GT4469@intel.com>
References: <1366220252-9574-1-git-send-email-ville.syrjala@linux.intel.com>
	<CA+gsUGRYNpUk8sdeBa4yUwLK1TRYMKMSjbx4Ckjy7zE6dNY=Mw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org>
Content-Disposition: inline
In-Reply-To: <CA+gsUGRYNpUk8sdeBa4yUwLK1TRYMKMSjbx4Ckjy7zE6dNY=Mw@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
To: Paulo Zanoni <przanoni@gmail.com>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>, DRI Development <dri-devel@lists.freedesktop.org>
List-Id: dri-devel@lists.freedesktop.org

On Wed, Apr 17, 2013 at 05:38:57PM -0300, Paulo Zanoni wrote:
> 2013/4/17  <ville.syrjala@linux.intel.com>:
> > This series attempts to make our CEA mode matching recognize both the
> > 60Hz and 59.94Hz variants of the modes (and similarly for 24/23.97,
> > 30/29.97, etc.).
> >
> > The benefits should include:
> > - Send the correct VIC in the AVI infoframe
> > - Pick the correct RGB quantization range in automatic mode
> =

> Everything looks correct, but I really didn't test anything. If you
> apply my comments from patch 2, then you have "Reviewed-by: Paulo
> Zanoni <paulo.r.zanoni@intel.com>" for all the 4 patches.

Thanks for the review.

> =

> Optional bikeshedding: you could add a follow-up patch fixing the
> comments inside edid_cea_modes to reflect the correct Hz used,
> replacing, for example, "AxB@60Hz" with "AxB@59.94Hz". But I can
> certainly live without this :)

I think I'll defer on that one until we decide whether we want add
both 60Hz and 59.94HZ versions to the connector's mode list. Daniel
suggested we do it, but I disagree slightly since CEA-861 says that
monitors should only advertise one variant in their detailed timings.
I was thinking that we'd follow that rule here as well. But I can
be easily convinced otherwise, in case someone else has an
opinion...

-- =

Ville Syrj=E4l=E4
Intel OTC