From: Dan Carpenter <dan.carpenter@oracle.com>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: sameo@linux.intel.com, mchehab@redhat.com, hverkuil@xs4all.nl,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 12/12] radio-si476x: Fix incorrect pointer checking
Date: Thu, 18 Apr 2013 20:48:15 +0300 [thread overview]
Message-ID: <20130418174815.GB26896@mwanda> (raw)
In-Reply-To: <1366304318-29620-13-git-send-email-andrew.smirnov@gmail.com>
On Thu, Apr 18, 2013 at 09:58:38AM -0700, Andrey Smirnov wrote:
> Fix incorrect pointer checking and make some minor code improvements:
>
> * Remove unnecessary elements from function pointer table(vtable),
> that includes all the elements that are FM-only, this allows for not
> checking of the fucntion pointer and calling of the function
> directly(THe check if the tuner is in FM mode has to be done anyway)
>
> * Fix incorrect function pointer checking where the code would check one
> pointer to be non-NULL, but would use other pointer, which would not
> be checked.
>
> * Remove code duplication in "si476x_radio_read_rsq_blob" and
> "si476x_radio_read_rsq_primary_blob".
>
> * Add some BUG_ON statements for function pointers that should never be NULL
>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
This should be a Reported-by for me, probably.
regards,
dan carpenter
next prev parent reply other threads:[~2013-04-18 17:48 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-18 16:58 [PATCH v9 00/12] Driver for Si476x series of chips Andrey Smirnov
2013-04-18 16:58 ` [PATCH 01/12] mfd: Add commands abstraction layer for SI476X MFD Andrey Smirnov
2013-04-18 16:58 ` [PATCH 02/12] mfd: Add the main bulk of core driver for SI476x code Andrey Smirnov
2013-04-18 16:58 ` [PATCH 03/12] mfd: Add chip properties handling code for SI476X MFD Andrey Smirnov
2013-04-18 16:58 ` [PATCH 04/12] mfd: Add header files and Kbuild plumbing for SI476x MFD core Andrey Smirnov
2013-04-18 16:58 ` [PATCH 05/12] v4l2: Fix the type of V4L2_CID_TUNE_PREEMPHASIS in the documentation Andrey Smirnov
2013-04-18 16:58 ` [PATCH 06/12] v4l2: Add standard controls for FM receivers Andrey Smirnov
2013-04-18 16:58 ` [PATCH 07/12] v4l2: Add documentation for the FM RX controls Andrey Smirnov
2013-04-18 16:58 ` [PATCH 08/12] v4l2: Add private controls base for SI476X Andrey Smirnov
2013-04-18 16:58 ` [PATCH 09/12] v4l2: Add a V4L2 driver for SI476X MFD Andrey Smirnov
2013-04-18 22:26 ` Samuel Ortiz
2013-04-18 16:58 ` [PATCH 10/12] radio-si476x: vidioc_s* now uses a const parameter Andrey Smirnov
2013-04-18 16:58 ` [PATCH 11/12] si476x: Fix some config dependencies and a compile warnings Andrey Smirnov
2013-04-18 17:56 ` Samuel Ortiz
2013-04-18 16:58 ` [PATCH 12/12] radio-si476x: Fix incorrect pointer checking Andrey Smirnov
2013-04-18 17:48 ` Dan Carpenter [this message]
2013-04-18 17:28 ` [PATCH v9 00/12] Driver for Si476x series of chips Mauro Carvalho Chehab
2013-04-18 17:45 ` Samuel Ortiz
2013-04-18 17:57 ` Mauro Carvalho Chehab
2013-04-18 18:17 ` Samuel Ortiz
2013-04-18 18:23 ` Samuel Ortiz
2013-04-18 20:27 ` Mauro Carvalho Chehab
2013-04-19 21:31 ` Samuel Ortiz
2013-04-19 21:48 ` Andrey Smirnov
2013-04-21 5:53 ` Andrey Smirnov
2013-04-21 9:33 ` Mauro Carvalho Chehab
2013-04-22 2:01 ` Andrey Smirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130418174815.GB26896@mwanda \
--to=dan.carpenter@oracle.com \
--cc=andrew.smirnov@gmail.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.