From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [libnftables PATCH v2] Basic support for printing nft_data_reg in XML format.
Date: Fri, 19 Apr 2013 01:24:10 +0200 [thread overview]
Message-ID: <20130418232410.GA16815@localhost> (raw)
In-Reply-To: <CAOkSjBg9WD5E_ePjdat-E8vb1cXAMTafaF-FyW4-e49q7Uo7Rw@mail.gmail.com>
On Tue, Apr 09, 2013 at 10:26:48PM +0200, Arturo Borrero Gonzalez wrote:
> 2013/4/9 Pablo Neira Ayuso <pablo@netfilter.org>:
> >
> > Cannot use "data" instead of immediate data? This is nested in
> > <immediate>...</immediate>, it seems redundant to me.
>
> Understood. And I will fix it.
>
> But let me explain why I did it:
>
> for example, cmp is using <cmpdata>
> <cmpdata> has <data_reg></data_reg> which can also be redundant.
>
> But all around the XML printing (including sets, an incoming patch)
> i've been nesting the data_reg into another XML node, so you could
> easily see (also the XML parser) the difference between (for example.
> in set) nft_set_elem->key and nft_set_elem->data.
> As I needed to nest in nft_set_elem I decided to follow a constant
> line and do nest all data_reg.
Fair enough. I have applied this patch.
prev parent reply other threads:[~2013-04-18 23:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-08 8:30 [libnftables PATCH v2] Basic support for printing nft_data_reg in XML format Arturo Borrero
2013-04-09 19:42 ` Pablo Neira Ayuso
2013-04-09 20:26 ` Arturo Borrero Gonzalez
2013-04-18 23:24 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130418232410.GA16815@localhost \
--to=pablo@netfilter.org \
--cc=arturo.borrero.glez@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.