From: Theodore Ts'o <tytso@mit.edu>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Zheng Liu <gnehzuil.liu@gmail.com>,
Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] ext4: disable defrag for metadata_csum file systems
Date: Fri, 19 Apr 2013 02:19:09 -0400 [thread overview]
Message-ID: <20130419061909.GB10053@thunk.org> (raw)
In-Reply-To: <20130419061727.GA10053@thunk.org>
On Fri, Apr 19, 2013 at 02:17:27AM -0400, Theodore Ts'o wrote:
> On Thu, Apr 18, 2013 at 10:47:38PM -0700, Darrick J. Wong wrote:
> >
> > I think this happens because mext_insert_extents() open-codes the metadata
> > dirtying and forgets to update the extent block header. It should call
> > ext4_ext_dirty() at the end, instead. :(
>
> Yes. The following patch seems to fix the problem.
Ah, I see you posted a similar patch. I'll take yours, since it's cleaner.
- Ted
prev parent reply other threads:[~2013-04-19 6:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-18 21:58 [PATCH] ext4: disable defrag for metadata_csum file systems Theodore Ts'o
2013-04-18 23:13 ` Zheng Liu
2013-04-19 5:47 ` Darrick J. Wong
2013-04-19 6:17 ` Theodore Ts'o
2013-04-19 6:19 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130419061909.GB10053@thunk.org \
--to=tytso@mit.edu \
--cc=darrick.wong@oracle.com \
--cc=gnehzuil.liu@gmail.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.