From: Johan Hedberg <johan.hedberg@gmail.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Tedd Ho-Jeong An <tedd.an@intel.com>,
linux-bluetooth@vger.kernel.org, don.fry@intel.com,
gustavo@padovan.org
Subject: Re: [PATCH v5] Bluetooth: Add support for Intel Bluetooth device [8087:07dc]
Date: Fri, 19 Apr 2013 10:16:09 +0300 [thread overview]
Message-ID: <20130419071609.GA3214@x220> (raw)
In-Reply-To: <1FD1A5F4-36D2-44E0-BBA8-BA5147C7322D@holtmann.org>
Hi Marcel,
On Thu, Apr 18, 2013, Marcel Holtmann wrote:
> >>> + u8 mfg_enable[] = { 0x01, 0x00 };
> >>> + u8 mfg_disable[] = { 0x00, 0x00 };
> >>> + u8 mfg_reset_deactivate[] = { 0x00, 0x01 };
> >>> + u8 mfg_reset_activate[] = { 0x00, 0x02 };
> >>
> >> Check if you can make these const.
> >
> > If these becomes const, the compiler throws a warning at __hci_cmd_sync() below.
>
> That is what I almost figured.
>
> Johan, can you check if we can fix __hci_cmd_sync to take a const array.
Done. The patch for this is now on the list.
Johan
prev parent reply other threads:[~2013-04-19 7:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-18 18:27 [PATCH v5] Bluetooth: Add support for Intel Bluetooth device [8087:07dc] Tedd Ho-Jeong An
2013-04-18 18:47 ` Marcel Holtmann
2013-04-18 23:06 ` Tedd Ho-Jeong An
2013-04-19 0:51 ` Marcel Holtmann
2013-04-19 1:44 ` Tedd Ho-Jeong An
2013-04-19 7:16 ` Johan Hedberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130419071609.GA3214@x220 \
--to=johan.hedberg@gmail.com \
--cc=don.fry@intel.com \
--cc=gustavo@padovan.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=tedd.an@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.