Re: [PATCH 0/7] Add capture support to compress API

[Vinod Koul <vinod.koul@intel.com>]

On Fri, Apr 19, 2013 at 03:41:11PM +0200, Takashi Iwai wrote:
> At Thu, 18 Apr 2013 10:58:41 +0100,
> Richard Fitzgerald wrote:
> > 
> > This chain of patches does some clearing up and add capture
> > support to the compressed API.
> > 
> > Missing is support for capture streams that don't use the
> > copy callback. Also I have included two patches at the end
> > of the chain that remove the buffer pointers and just use
> > the cumulative values however as our setup uses the copy
> > callback these are untested past build so should be taken
> > with caution.
> > 
> > Thanks,
> > Charles
> > 
> > Thess patches apply to:
> >   git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git
> >   branch "for-next"
> > 
> > based on top of commit
> >   126825e ALSA: snd-usb: add quirks handler for DSD streams
> 
> Vinod, Pierre, could you guys check these patches?
> 
> If these are OK, I can still merge for 3.10.  Although it's already
> late for 3.10, there are little users of compress stuff, so the impact
> must be fairly small.  If you guys aren't still happy, let's postpone
> for 3.11.
Sorry for delay and thrash on patches, my sound clone was bad...

I think I am okay with series approach. We need small fix for state check for
read but that need not block this series

Acked-by: Vinod Koul <vinod.koul@intel.com>
> 
> 
> If we really merge it, don't you mind me merging soc-compress patch in
> my tree (directly to for-next branch), Mark?
i think that should be sensible :)

--
~Vinod
> 
> 
> thanks,
> 
> Takashi
> 
> > 
> > - RichF
> > 
> > Charles Keepax (7):
> >   ALSA: compress_core: Update calc_avail to use cumulative values
> >   ALSA: compress_core: Calculate avail correctly for capture streams
> >   ALSA: compress_core: Deconstify copy callback buffer
> >   ALSA: compress_core: Add support for capture streams
> >   ASoC: soc-compress: Deduce stream direction
> >   ALSA: compress_core: Remove unused hw_pointer
> >   ALSA: compress_core: Rework writes to use cumulative values
> > 
> >  include/sound/compress_driver.h |    4 +-
> >  sound/core/compress_offload.c   |  117 +++++++++++++++++++++++++-------------
> >  sound/soc/soc-compress.c        |   11 +++-
> >  3 files changed, 87 insertions(+), 45 deletions(-)
> > 
> > -- 
> > 1.7.2.5
> >