From: Arnd Bergmann <arnd@arndb.de>
To: "Lars-Peter Clausen" <lars@metafoo.de>
Cc: Vinod Koul <vinod.koul@intel.com>, Jon Hunter <jon-hunter@ti.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] dma:of: Use a mutex to protect the of_dma_list
Date: Fri, 19 Apr 2013 14:25:44 +0200 [thread overview]
Message-ID: <201304191425.44963.arnd@arndb.de> (raw)
In-Reply-To: <517124D6.7090008@metafoo.de>
On Friday 19 April 2013, Lars-Peter Clausen wrote:
> Well, It's not only about the of_dma struct, e.g. the of_dma's of_dma_data
> field usually points to some driver allocated data. If we do not block in
> of_dma_controller_free() this data might be freed while the controller is
> still in use.
Right, makes sense. This could of course be worked around using a destructor
in the of_dma struct, but your approach is much simpler.
Arnd
next prev parent reply other threads:[~2013-04-19 12:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-19 9:42 [PATCH 1/2] dma: of: Fix of_node reference leak Lars-Peter Clausen
2013-04-19 9:42 ` [PATCH 2/2] dma:of: Use a mutex to protect the of_dma_list Lars-Peter Clausen
2013-04-19 10:13 ` Arnd Bergmann
2013-04-19 11:04 ` Lars-Peter Clausen
2013-04-19 12:25 ` Arnd Bergmann [this message]
2013-04-19 22:45 ` Jon Hunter
2013-04-19 23:13 ` Arnd Bergmann
2013-04-22 1:22 ` Jon Hunter
2013-04-20 7:28 ` Lars-Peter Clausen
2013-04-20 10:38 ` Arnd Bergmann
2013-04-22 1:18 ` Jon Hunter
2013-04-19 10:10 ` [PATCH 1/2] dma: of: Fix of_node reference leak Arnd Bergmann
2013-04-19 22:29 ` Jon Hunter
2013-05-02 16:24 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201304191425.44963.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=jon-hunter@ti.com \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.