All of lore.kernel.org
 help / color / mirror / Atom feed
From: Theodore Ts'o <tytso@mit.edu>
To: Tao Ma <tm@tao.ma>
Cc: linux-ext4@vger.kernel.org, zab@redhat.com
Subject: Re: [PATCH 2/2] ext4: fix readdir error in case inline_data+^dir_index.
Date: Fri, 19 Apr 2013 18:00:18 -0400	[thread overview]
Message-ID: <20130419220018.GB13249@thunk.org> (raw)
In-Reply-To: <1365608228-3950-2-git-send-email-tm@tao.ma>

On Wed, Apr 10, 2013 at 11:37:08PM +0800, Tao Ma wrote:
> From: Tao Ma <boyu.mt@taobao.com>
> 
> Zach reported a problem that if inline data is enabled, we don't
> tell the difference between the offset of '.' and '..'. And a
> getdents will fail if the user only want to get '.'. And what's
> worse, we may meet with duplicate dir entries as the offset
> for inline dir and non-inline one is quite different.
> 
> This patch just try to resolve this problem if dir_index
> is disabled. In this case, f_pos is the real offset with
> the dir block, so for inline dir, we just pretend as if
> we are a dir block and returns the offset like a norml
> dir block does.
> 
> Reported-by: Zach Brown <zab@redhat.com>
> Signed-off-by: Tao Ma <boyu.mt@taobao.com>

Thanks, applied.

					- Ted

  reply	other threads:[~2013-04-19 22:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-10 15:33 [PATCH 0/2] ext4: fix readdir error with getdents Tao Ma
2013-04-10 15:37 ` [PATCH 1/2] ext4: fix readdir error in case inline_data+dir_index Tao Ma
2013-04-10 15:37   ` [PATCH 2/2] ext4: fix readdir error in case inline_data+^dir_index Tao Ma
2013-04-19 22:00     ` Theodore Ts'o [this message]
2013-04-12 21:55   ` [PATCH 1/2] ext4: fix readdir error in case inline_data+dir_index Zach Brown
2013-04-19 22:00   ` Theodore Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130419220018.GB13249@thunk.org \
    --to=tytso@mit.edu \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tm@tao.ma \
    --cc=zab@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.