From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] ARM: default machine descriptor for multiplatform
Date: Fri, 19 Apr 2013 23:54:24 +0200 [thread overview]
Message-ID: <201304192354.25065.arnd@arndb.de> (raw)
In-Reply-To: <5171B7F8.4040601@gmail.com>
On Friday 19 April 2013, Rob Herring wrote:
> This will fail to build for !OF. of_platform.h needs this:
>
> #define of_default_bus_match_table NULL
>
> You may need some struct forward declarations, but this commit in my
> tree for 3.10 should fix those:
>
> commit d450f445f9a654080a6be4094376c2192d9a1f36
> Author: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Date: Tue Feb 19 02:58:25 2013 +0300
>
> <linux/of_platform.h>: fix compilation warnings with DT disabled
>
Ok. I've actually stumbled over missing declarations from of_platform.h
and related files a number of times. Could we please not hide any
declarations inside of #ifdef when there is no #else alternative?
If we just show the of_default_bus_match_table declaration in the
header file, there is no need to provide the silly NULL macro,
since the of_platform_populate alternative will just ignore it.
I'll just put the code in an #ifdef for now, but I'd really prefer
to clean up this and many other locations that currently have
to do #ifdef CONFIG_OF when they really don't need to.
Arnd
next prev parent reply other threads:[~2013-04-19 21:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-12 15:11 [PATCH 1/2] ARM: default machine descriptor for multiplatform Arnd Bergmann
2013-04-12 15:11 ` [PATCH 2/2] ARM: remove all trivial init_machine callbacks Arnd Bergmann
2013-04-12 15:19 ` Arnd Bergmann
2013-04-12 15:40 ` Stephen Warren
2013-04-12 16:03 ` Arnd Bergmann
2013-04-12 16:08 ` Jean-Christophe PLAGNIOL-VILLARD
2013-04-19 13:28 ` [PATCH 1/2] ARM: default machine descriptor for multiplatform Russell King - ARM Linux
2013-04-19 14:21 ` Arnd Bergmann
2013-04-19 14:40 ` [PATCH v3] " Arnd Bergmann
2013-04-19 21:32 ` Rob Herring
2013-04-19 21:54 ` Arnd Bergmann [this message]
2013-04-19 22:22 ` Rob Herring
2013-04-19 23:11 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201304192354.25065.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.