All of lore.kernel.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: linux-next ARM multi-platform randconfig errors
Date: Sat, 20 Apr 2013 00:08:28 +0200	[thread overview]
Message-ID: <201304200008.28716.arnd@arndb.de> (raw)
In-Reply-To: <20130419215134.GY10155@atomide.com>

On Friday 19 April 2013, Tony Lindgren wrote:
> In this case the options within the ifeq have already been tested
> with randconfigs. The reason for these build errors is that no SoC
> has been selected, and there's nothing implementing the the missing
> functions. The other option for fixing the issue would be to add a
> null SoC, which probably does not make sense in this case.
> 
> I've been building various omap2+ randconfigs for quite a while,
> and in general they work with a few warnings left. But I've
> been doing that with at least one SoC selected earlier because
> of the historic "must select a target board" that no longer is
> the case with your patch.

I think part of the problem is the way the Makefile is laid
out, e.g.

clockdomain-common                      += clockdomain.o
obj-$(CONFIG_ARCH_OMAP2)                += $(clockdomain-common)
obj-$(CONFIG_ARCH_OMAP3)                += $(clockdomain-common)
obj-$(CONFIG_ARCH_OMAP4)                += $(clockdomain-common)
obj-$(CONFIG_SOC_AM33XX)                += $(clockdomain-common)
obj-$(CONFIG_SOC_OMAP5)                 += $(clockdomain-common)

This results in building clockdomain.o whenever any of the various
SoCs are enabled, but not when none of them are enabled.

However, according to the error messages, this driver is actually
referenced by code that is enabled unconditionally.

You are right that your patch would fix this scenario, but it does
so by adding extra logic, not by simplifying it. I can see two ways
to make that more logical:

a) use the new Kconfig symbol consistently:
obj-$(CONFIG_SOC_OMAP)			+= clockdomain.o

b) don't introduce a new symbol but use the Makefile consistently
omap-common += io.o mux.o devices.o fb.o serial.o gpmc.o timer.o pm.o \
         common.o gpio.o dma.o wd_timer.o display.o i2c.o hdq1w.o omap_hwmod.o \
         omap_device.o sram.o
obj-$(CONFIG_ARCH_OMAP2)                += $(omap-common)
obj-$(CONFIG_ARCH_OMAP3)                += $(omap-common)
obj-$(CONFIG_ARCH_OMAP4)                += $(omap-common)
obj-$(CONFIG_SOC_AM33XX)                += $(omap-common)
obj-$(CONFIG_SOC_OMAP5)                 += $(omap-common)

	Arnd

  parent reply	other threads:[~2013-04-19 22:08 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-19  3:06 linux-next ARM multi-platform randconfig errors Rob Herring
2013-04-19 16:12 ` Tony Lindgren
2013-04-19 16:41   ` Tomi Valkeinen
2013-04-19 19:43     ` Tony Lindgren
2013-04-19 19:51       ` Tony Lindgren
2013-04-19 20:11       ` Arnd Bergmann
2013-04-19 20:40         ` Tony Lindgren
2013-04-19 20:58           ` Arnd Bergmann
     [not found]             ` <20130419215134.GY10155@atomide.com>
2013-04-19 22:08               ` Arnd Bergmann [this message]
2013-04-19 22:53                 ` Paul Walmsley
2013-04-19 21:02           ` Tony Lindgren
2013-04-19 21:09           ` Tony Lindgren
2013-04-19 19:52     ` Jon Hunter
2013-04-19 20:42       ` Tony Lindgren
2013-04-19 17:23   ` Tony Lindgren
2013-04-22  7:23   ` Roger Quadros
2013-04-22  8:21     ` Felipe Balbi
2013-04-22 11:52       ` Felipe Balbi
2013-04-22 12:45         ` Kishon Vijay Abraham I
2013-04-22 13:04           ` Felipe Balbi
2013-04-22 17:32 ` Mikulas Patocka
2013-04-22 22:57   ` Rob Herring
2013-05-13 22:37     ` [PATCH] bcache: Fix link errors on ARM Mikulas Patocka
2013-05-13 22:37       ` Mikulas Patocka
2013-04-22 18:59 ` linux-next ARM multi-platform randconfig errors Mike Turquette

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201304200008.28716.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.