From: Borislav Petkov <bp@alien8.de>
To: Jiri Slaby <jslaby@suse.cz>, Ingo Molnar <mingo@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
John Stultz <john.stultz@linaro.org>,
Linux-pm mailing list <linux-pm@lists.linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: Resume does not work after timekeeping change
Date: Sat, 20 Apr 2013 20:41:52 +0200 [thread overview]
Message-ID: <20130420184152.GA4649@pd.tnic> (raw)
In-Reply-To: <5172B86C.5030606@suse.cz>
On Sat, Apr 20, 2013 at 05:46:52PM +0200, Jiri Slaby wrote:
> Hi,
>
> my machine does not wake from suspend to RAM on my box running the -next
> kernel. The last thing I see is "Disabling non-boot CPUs ...". I
> bisected it to this commit:
>
> commit 7ec98e15aa049b7a2ca73485f31cf4f90c34e2dd
> Author: Thomas Gleixner <tglx@linutronix.de>
> Date: Thu Feb 21 22:51:39 2013 +0000
>
> timekeeping: Delay update of clock->cycle_last
>
>
> Reverting that one on the top of -next-20130419 makes it work again.
>
>
> I also tried it inside a VM using suspend to disk. There, it behaves
> like it takes a minute or so to wake up. So I tried to wait on the real
> HW too, but it never resumes there.
Right, and I'm seeing it here too but it sometimes does resume after
about a minute or so and sometimes it doesn't.
Reverting the patch by hand ontop of tip/master fixes the issue here
too.
Btw, Ingo, remember how I was telling you that I'm seeing
temporary lockups with tip/master and resume issues
with the last line being "Disabling non-boot CPUs ..."
http://marc.info/?l=linux-kernel&m=136610574502492 - this commit was the
culprit.
Good job Jiri.
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
next prev parent reply other threads:[~2013-04-20 18:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-20 15:46 Resume does not work after timekeeping change Jiri Slaby
2013-04-20 18:41 ` Borislav Petkov [this message]
2013-04-21 14:48 ` Thomas Gleixner
2013-04-21 16:39 ` Borislav Petkov
2013-04-22 17:01 ` John Stultz
2013-04-22 18:32 ` [tip:timers/core] timekeeping: Update tk->cycle_last in resume tip-bot for Thomas Gleixner
2013-04-22 16:05 ` Resume does not work after timekeeping change John Stultz
2013-04-22 16:40 ` John Stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130420184152.GA4649@pd.tnic \
--to=bp@alien8.de \
--cc=john.stultz@linaro.org \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.