From: Greg KH <gregkh@linuxfoundation.org>
To: Anatol Pomozov <anatol.pomozov@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] kref: minor cleanup
Date: Sat, 20 Apr 2013 15:31:03 -0700 [thread overview]
Message-ID: <20130420223103.GA15927@kroah.com> (raw)
In-Reply-To: <CAOMFOmU2ig8JXb_+YtQGHkU5+c19S7Y=qWXjb+0HE1TwmLO3kw@mail.gmail.com>
On Fri, Apr 19, 2013 at 09:27:20PM -0700, Anatol Pomozov wrote:
> >> -static struct kobject *kobject_get_unless_zero(struct kobject *kobj)
> >> +static struct kobject *__must_check kobject_get_unless_zero(
> >> + struct kobject *kobj)
> >
> > __must_check needs to be in the .h file, not the .c file.
>
> This function is static and defined in *.c. But I think the function
> should be declared in *.h as it might be useful for others. I'll
> resend patch tomorrow.
No, I was trying to give you a hint in that it is not needed because
this function is not exported, sorry for being vague.
greg k-h
next prev parent reply other threads:[~2013-04-20 22:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-20 1:33 [PATCH] kref: minor cleanup Anatol Pomozov
2013-04-20 2:24 ` Greg KH
2013-04-20 4:27 ` Anatol Pomozov
2013-04-20 22:31 ` Greg KH [this message]
2013-04-20 16:15 ` Anatol Pomozov
2013-04-20 22:34 ` Greg KH
2013-04-25 1:38 ` Anatol Pomozov
-- strict thread matches above, loose matches on Subject: below --
2013-05-07 22:37 Anatol Pomozov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130420223103.GA15927@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=anatol.pomozov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.