From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Enable PCIe port 1 on QNAP TS-11x/TS-21x
Date: Sun, 21 Apr 2013 17:47:04 +0200 [thread overview]
Message-ID: <20130421154704.GV2824@lunn.ch> (raw)
In-Reply-To: <20130421152802.GA1408@jirafa.cyrius.com>
On Sun, Apr 21, 2013 at 04:28:02PM +0100, Martin Michlmayr wrote:
> Enable KW_PCIE1 on QNAP TS-11x/TS-21x devices as newer revisions
> (rev 1.3) have a USB 3.0 chip from Etron on PCIe port 1. Thanks
> to Marek Vasut for identifying this issue!
>
> Cc: <stable@kernel.org>
> Signed-off-by: Martin Michlmayr <tbm@cyrius.com>
> Tested-by: Marek Vasut <marex@denx.de>
>
> diff --git a/arch/arm/mach-kirkwood/board-ts219.c b/arch/arm/mach-kirkwood/board-ts219.c
> index acb0187..651e6b3 100644
> --- a/arch/arm/mach-kirkwood/board-ts219.c
> +++ b/arch/arm/mach-kirkwood/board-ts219.c
> @@ -46,7 +46,7 @@ void __init qnap_dt_ts219_init(void)
> static int __init ts219_pci_init(void)
> {
> if (machine_is_ts219())
> - kirkwood_pcie_init(KW_PCIE0);
> + kirkwood_pcie_init(KW_PCIE1 | KW_PCIE0);
>
Hi Martin
For the DT based board, this will not help. Did you notice the FIXME?
Now that i know both ports are needed, i will fix the DT for 3.11 when
we introduce PCI bindings via DT.
> return 0;
> }
> diff --git a/arch/arm/mach-kirkwood/ts219-setup.c b/arch/arm/mach-kirkwood/ts219-setup.c
> index 283abff..e1267d6 100644
> --- a/arch/arm/mach-kirkwood/ts219-setup.c
> +++ b/arch/arm/mach-kirkwood/ts219-setup.c
> @@ -124,7 +124,7 @@ static void __init qnap_ts219_init(void)
> static int __init ts219_pci_init(void)
> {
> if (machine_is_ts219())
> - kirkwood_pcie_init(KW_PCIE0);
> + kirkwood_pcie_init(KW_PCIE1 | KW_PCIE0);
This looks correct. Please could you submit a new version with just
this hunk. Since its a fix, we can probably get it quickly into 3.10
and then into stable.
Thanks
Andrew
next prev parent reply other threads:[~2013-04-21 15:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-21 15:28 [PATCH] Enable PCIe port 1 on QNAP TS-11x/TS-21x Martin Michlmayr
2013-04-21 15:47 ` Andrew Lunn [this message]
2013-04-21 16:12 ` Martin Michlmayr
2013-04-21 16:14 ` [PATCH] Kirkwood: " Martin Michlmayr
2013-04-21 17:03 ` Andrew Lunn
2013-04-29 17:30 ` Jason Cooper
2013-04-29 18:03 ` Andrew Lunn
2013-04-29 18:24 ` Jason Cooper
2013-05-13 16:45 ` Jason Cooper
2013-05-13 16:01 ` Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130421154704.GV2824@lunn.ch \
--to=andrew@lunn.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.