From mboxrd@z Thu Jan  1 00:00:00 1970
From: arnd@arndb.de (Arnd Bergmann)
Date: Mon, 22 Apr 2013 13:36:21 +0200
Subject: [PATCH 03/23] ARM: u300: device tree support for the timer
In-Reply-To: <1366624304-6190-1-git-send-email-linus.walleij@stericsson.com>
References: <1366624304-6190-1-git-send-email-linus.walleij@stericsson.com>
Message-ID: <201304221336.21921.arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

On Monday 22 April 2013, Linus Walleij wrote:
> +#ifdef CONFIG_OF
> +       struct device_node *timer = NULL;
> +
> +       timer = of_find_node_by_path("/timer0 at c0014000");
> +       if (timer) {
> +               struct resource irq_res;
> +
> +               u300_timer_base = of_iomap(timer, 0);
> +               /* Get the IRQ for the GP1 timer */
> +               irq = of_irq_to_resource(timer, 2, &irq_res);
> +       }
> +#endif

Do you need the #ifdef? The functions should be defined in a way that
removes this code if CONFIG_OF is not defined.

	Arnd

From mboxrd@z Thu Jan  1 00:00:00 1970
From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
Subject: Re: [PATCH 03/23] ARM: u300: device tree support for the timer
Date: Mon, 22 Apr 2013 13:36:21 +0200
Message-ID: <201304221336.21921.arnd@arndb.de>
References: <1366624304-6190-1-git-send-email-linus.walleij@stericsson.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>
In-Reply-To: <1366624304-6190-1-git-send-email-linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org>
List-Unsubscribe: <https://lists.ozlabs.org/options/devicetree-discuss>,
 <mailto:devicetree-discuss-request-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org?subject=unsubscribe>
List-Archive: <http://lists.ozlabs.org/pipermail/devicetree-discuss/>
List-Post: <mailto:devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>
List-Help: <mailto:devicetree-discuss-request-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org?subject=help>
List-Subscribe: <https://lists.ozlabs.org/listinfo/devicetree-discuss>,
 <mailto:devicetree-discuss-request-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org?subject=subscribe>
Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
Sender: "devicetree-discuss"
 <devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>
To: Linus Walleij <linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org>
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
List-Id: devicetree@vger.kernel.org

On Monday 22 April 2013, Linus Walleij wrote:
> +#ifdef CONFIG_OF
> +       struct device_node *timer = NULL;
> +
> +       timer = of_find_node_by_path("/timer0@c0014000");
> +       if (timer) {
> +               struct resource irq_res;
> +
> +               u300_timer_base = of_iomap(timer, 0);
> +               /* Get the IRQ for the GP1 timer */
> +               irq = of_irq_to_resource(timer, 2, &irq_res);
> +       }
> +#endif

Do you need the #ifdef? The functions should be defined in a way that
removes this code if CONFIG_OF is not defined.

	Arnd