From: Dan Carpenter <dan.carpenter@oracle.com>
To: Shankar Brahadeeswaran <shankoo77@gmail.com>
Cc: Robert Love <rlove@google.com>,
LKML <linux-kernel@vger.kernel.org>,
Bjorn Bringert <bringert@google.com>,
Al Viro <viro@zeniv.linux.org.uk>,
devel@driverdev.osuosl.org, Hugh Dickins <hughd@google.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
anjanavk12@gmail.com
Subject: Re: [BUG] staging: android: ashmem: Deadlock during ashmem_shrink
Date: Mon, 22 Apr 2013 17:22:18 +0300 [thread overview]
Message-ID: <20130422142218.GA26760@mwanda> (raw)
In-Reply-To: <CAJsYZ5kk=J_Sc7w5dbMbkWWv8dXEU0ojKjEKNqH=Q6Tf2f7mQg@mail.gmail.com>
Read Al's email again: https://lkml.org/lkml/2013/3/20/458
I don't know much about VFS locking, but the ashmem locking seems
pretty bogus to me. Why can't multiple threads read() at the same
time?
One thing is that it should probably be broken into different locks
instead of a mini-BKL. Instead of taking a bad design and trying to
hack it until it doesn't crash I think it would be better to redo
the locking from scratch.
regards,
dan carpenter
next parent reply other threads:[~2013-04-22 14:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAJsYZ5kk=J_Sc7w5dbMbkWWv8dXEU0ojKjEKNqH=Q6Tf2f7mQg@mail.gmail.com>
2013-04-22 14:22 ` Dan Carpenter [this message]
2013-04-22 14:43 ` [BUG] staging: android: ashmem: Deadlock during ashmem_shrink Robert Love
2013-04-23 16:20 ` Shankar Brahadeeswaran
2013-04-23 17:24 ` Robert Love
2013-04-25 13:54 ` Shankar Brahadeeswaran
2013-04-25 14:13 ` Shankar Brahadeeswaran
2013-04-25 15:05 ` Robert Love
2013-04-30 13:29 ` Shankar Brahadeeswaran
2013-04-30 22:32 ` Robert Love
2013-04-30 23:33 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130422142218.GA26760@mwanda \
--to=dan.carpenter@oracle.com \
--cc=anjanavk12@gmail.com \
--cc=bringert@google.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rlove@google.com \
--cc=shankoo77@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.