All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hedberg <johan.hedberg@gmail.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Alex Deymo <deymo@chromium.org>,
	linux-bluetooth <linux-bluetooth@vger.kernel.org>,
	keybuk <keybuk@chromium.org>
Subject: Re: [PATCH v7 0/5] input: Connectability
Date: Tue, 23 Apr 2013 10:42:42 +0300	[thread overview]
Message-ID: <20130423074242.GA5111@x220> (raw)
In-Reply-To: <51409ECB-5F03-473F-A257-72EE1540B571@holtmann.org>

Hi,

On Mon, Apr 22, 2013, Marcel Holtmann wrote:
> >> However I do have a general question, do we need the new D-Bus API
> >> if we do an auto-reconnect handling? If so, do we need to indicate
> >> that the we are currently in auto-reconnect mode and/or cancel it
> >> when connecting attempts via other means happen.
> > 
> > We still need the new D-Bus API to let the UI know that it can't
> > reconnect to the device because the device is not supposed to normally
> > accept connections (ReconnectMode is "device" (or "none" if such a
> > device exists)). This allows the UI to instruct the user to go and
> > move the mouse to reconnect or press that hidden "connect" button in
> > his device to reconnect it if the device had lost the pairing. If the
> > ReconnectMode is "device", the meaning of Device1.Connected property
> > changes a bit, since the fact that my mouse is disconnected right now
> > doesn't mean that it is not working as intended or that it should be
> > connected.
> 
> I might have should answered this email with an acknowledged and
> understood comment. Sorry about that.
> 
> My original comment still stands. I am fine with this patch set, but
> leave it up to Johan to make the final to apply it.

No major issues from my side either. All patches in the set have now
been applied.

Johan

      reply	other threads:[~2013-04-23  7:42 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-16 21:58 [PATCH v7 0/5] input: Connectability Alex Deymo
2013-04-16 21:58 ` [PATCH v7 1/5] input: Documentation for new Input1 interface Alex Deymo
2013-04-16 21:58 ` [PATCH v7 2/5] input: Implement the new ReconnectMode Input1 property Alex Deymo
2013-04-16 21:58 ` [PATCH v7 3/5] input: Convert gboolean to bool Alex Deymo
2013-04-16 21:58 ` [PATCH v7 4/5] input: Fix memory leak for hidp_connadd_req Alex Deymo
2013-04-16 21:58 ` [PATCH v7 5/5] input: Automatically attempt a reconnect when required Alex Deymo
2013-04-17 20:20 ` [PATCH v7 0/5] input: Connectability Marcel Holtmann
2013-04-17 20:37   ` Alex Deymo
2013-04-22 17:48     ` Alex Deymo
2013-04-22 19:27     ` Marcel Holtmann
2013-04-23  7:42       ` Johan Hedberg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130423074242.GA5111@x220 \
    --to=johan.hedberg@gmail.com \
    --cc=deymo@chromium.org \
    --cc=keybuk@chromium.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=marcel@holtmann.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.