All of lore.kernel.org
 help / color / mirror / Atom feed
From: marex@denx.de (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC][PATCH] video: imx: Select VIDEOMODE_HELPERS
Date: Tue, 23 Apr 2013 12:29:48 +0200	[thread overview]
Message-ID: <201304231229.48511.marex@denx.de> (raw)
In-Reply-To: <20130423050745.GO32299@pengutronix.de>

Dear Sascha Hauer,

> On Tue, Apr 23, 2013 at 01:57:47AM +0200, Marek Vasut wrote:
> > Dear Fabio Estevam,
> > 
> > > Hi Marek,
> > > 
> > > On Mon, Apr 22, 2013 at 6:28 PM, Marek Vasut <marex@denx.de> wrote:
> > > > Without this, I get the following problem when building kernel:
> > > > 
> > > > drivers/built-in.o: In function `imx_pd_connector_get_modes':
> > > > /linux-2.6/drivers/staging/imx-drm/parallel-display.c:78: undefined
> > > > reference to `of_get_drm_display_mode' make: *** [vmlinux] Error 1
> > > > 
> > > > NOTE: I think this patch is almost absolutely not correct.
> > > > 
> > > > Signed-off-by: Marek Vasut <marex@denx.de>
> > > > Cc: Sascha Hauer <s.hauer@pengutronix.de>
> > > > Cc: Philipp Zabel <p.zabel@pengutronix.de>
> > > > Cc: Fabio Estevam <fabio.estevam@freescale.com>
> > > 
> > > Patch looks good, but you should have copied Greg Kroah-Hartman, as he
> > > is the one who takes patches into staging.
> > 
> > I'm not sure if the select is at correct symbol, I dont think it is.
> 
> No it's not. The parallel display driver needs it, not the i.MX drm
> support in general.

Yep, I expected this coming, thus RFC. I'll roll out new patch and move this to 
parallel display, ok?

Best regards,
Marek Vasut

  reply	other threads:[~2013-04-23 10:29 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-22 21:28 [RFC][PATCH] video: imx: Select VIDEOMODE_HELPERS Marek Vasut
2013-04-22 22:35 ` Fabio Estevam
2013-04-22 23:57   ` Marek Vasut
2013-04-23  5:07     ` Sascha Hauer
2013-04-23 10:29       ` Marek Vasut [this message]
2013-04-23 17:43         ` Sascha Hauer
2013-04-23  7:41     ` Philipp Zabel
2013-04-24  0:31       ` Marek Vasut
2013-04-24  8:22         ` Philipp Zabel
2013-04-24  2:48       ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201304231229.48511.marex@denx.de \
    --to=marex@denx.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.