All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oleg Nesterov <oleg@redhat.com>
To: Jacob Shin <jacob.shin@amd.com>
Cc: Ingo Molnar <mingo@redhat.com>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	x86@kernel.org, Stephane Eranian <eranian@google.com>,
	Jiri Olsa <jolsa@redhat.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 2/4] perf/x86/amd: AMD implementation for hardware breakpoint address mask
Date: Tue, 23 Apr 2013 15:22:07 +0200	[thread overview]
Message-ID: <20130423132207.GB24467@redhat.com> (raw)
In-Reply-To: <1366703825-19373-3-git-send-email-jacob.shin@amd.com>

On 04/23, Jacob Shin wrote:
>
> +int arch_validate_hwbkpt_addr_mask(struct perf_event *bp)
> +{
> +	if (!cpu_has_bpext)
> +		return -EOPNOTSUPP;

I must have missed something...

But it shouldn't fail if bp_addr_mask == 0?

Oleg.


  reply	other threads:[~2013-04-23 13:25 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-23  7:57 [PATCH V2 0/4] perf: Add support for hardware breakpoint address masks Jacob Shin
2013-04-23  7:57 ` [PATCH V2 1/4] perf: Add hardware breakpoint address mask Jacob Shin
2013-04-23  9:54   ` Will Deacon
2013-04-23 14:34     ` Jacob Shin
2013-04-23 14:40       ` Jacob Shin
2013-04-23 15:02         ` Will Deacon
2013-04-23 15:18           ` Jacob Shin
2013-04-24  9:48             ` Will Deacon
2013-04-24 16:30               ` Jacob Shin
2013-04-25 17:06                 ` Oleg Nesterov
2013-04-25 17:17                   ` H. Peter Anvin
2013-04-25 23:19                     ` Jacob Shin
2013-04-26 16:20                       ` Will Deacon
2013-04-26 16:31                         ` Jacob Shin
2013-04-26 16:47                       ` Oleg Nesterov
2013-04-23 13:18   ` Oleg Nesterov
2013-04-23 14:25     ` Jacob Shin
2013-04-24 23:08       ` Frederic Weisbecker
2013-04-25 15:10         ` Oleg Nesterov
2013-04-25 15:57           ` Oleg Nesterov
2013-04-25 16:59           ` Jacob Shin
2013-04-25 17:33             ` Oleg Nesterov
2013-04-23  7:57 ` [PATCH V2 2/4] perf/x86/amd: AMD implementation for " Jacob Shin
2013-04-23 13:22   ` Oleg Nesterov [this message]
2013-04-23  7:57 ` [PATCH V2 3/4] perf tools: Add hardware breakpoint address mask event parser Jacob Shin
2013-04-23  7:57 ` [PATCH V2 4/4] perf tools: Add hardware breakpoint address mask test cases Jacob Shin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130423132207.GB24467@redhat.com \
    --to=oleg@redhat.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@ghostprotocols.net \
    --cc=eranian@google.com \
    --cc=fweisbec@gmail.com \
    --cc=hpa@zytor.com \
    --cc=jacob.shin@amd.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.