From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 02/15] drm/i915: Disable high-bpc on pre-1.4 EDID screens Date: Tue, 23 Apr 2013 18:07:16 +0300 Message-ID: <20130423150716.GF4469@intel.com> References: <1366363487-15926-1-git-send-email-daniel.vetter@ffwll.ch> <1366363487-15926-3-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id DE91DE621A for ; Tue, 23 Apr 2013 08:07:19 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1366363487-15926-3-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org On Fri, Apr 19, 2013 at 11:24:34AM +0200, Daniel Vetter wrote: > Prevents black screens when using 30bpp framebuffers on my > HDMI screens here. The DP input on the same screen though reports a > 1.4 EDID with the correct 8bpc limit set. > = > v2: Actually check for the right thing! > = > Signed-off-by: Daniel Vetter Reviewed-by: Ville Syrj=E4l=E4 > --- > drivers/gpu/drm/i915/intel_display.c | 7 +++++++ > 1 file changed, 7 insertions(+) > = > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/= intel_display.c > index 6e265b0..1e6efab 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c > @@ -7612,6 +7612,13 @@ pipe_config_set_bpp(struct drm_crtc *crtc, > bpp, connector->display_info.bpc*3); > pipe_config->pipe_bpp =3D connector->display_info.bpc*3; > } > + > + /* Clamp bpp to 8 on screens without EDID 1.4 */ > + if (connector->display_info.bpc =3D=3D 0 && bpp > 24) { > + DRM_DEBUG_KMS("clamping display bpp (was %d) to default limit of 24\n= ", > + bpp); > + pipe_config->pipe_bpp =3D 24; > + } > } > = > return bpp; > -- = > 1.7.11.7 > = > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- = Ville Syrj=E4l=E4 Intel OTC