From: Dave Chinner <david@fromorbit.com>
To: Brian Foster <bfoster@redhat.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: introduce CONFIG_XFS_WARN
Date: Wed, 24 Apr 2013 07:02:26 +1000 [thread overview]
Message-ID: <20130423210226.GN10481@dastard> (raw)
In-Reply-To: <5176833C.8070305@redhat.com>
On Tue, Apr 23, 2013 at 08:49:00AM -0400, Brian Foster wrote:
> On 04/23/2013 02:38 AM, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@redhat.com>
> >
> ...
> > diff --git a/fs/xfs/xfs_trans.h b/fs/xfs/xfs_trans.h
> > index cd29f61..d3e0679 100644
> > --- a/fs/xfs/xfs_trans.h
> > +++ b/fs/xfs/xfs_trans.h
> > @@ -405,7 +405,7 @@ typedef struct xfs_trans {
> > int64_t t_res_fdblocks_delta; /* on-disk only chg */
> > int64_t t_frextents_delta;/* superblock freextents chg*/
> > int64_t t_res_frextents_delta; /* on-disk only chg */
> > -#ifdef DEBUG
> > +#if defined(DEBUG) || defined(XFS_WARN)
> > int64_t t_ag_freeblks_delta; /* debugging counter */
> > int64_t t_ag_flist_delta; /* debugging counter */
> > int64_t t_ag_btree_delta; /* debugging counter */
> >
>
> I see some ASSERT() calls using these counters but the macros that
> manage them appear to be defined against DEBUG only (further down in
> xfs_trans.h). This looks like it would lead to spurious warnings..?
Yes, you are right - it should lead to warnings being emitted, but I
didn't see any when running xfstests. I'll fix it up.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-04-23 21:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-23 6:38 [PATCH] xfs: introduce CONFIG_XFS_WARN Dave Chinner
2013-04-23 12:49 ` Brian Foster
2013-04-23 21:02 ` Dave Chinner [this message]
2013-04-24 8:55 ` [PATCH V2] " Dave Chinner
2013-04-24 18:39 ` Chandra Seetharaman
2013-04-24 22:58 ` Dave Chinner
2013-04-25 0:21 ` Eric Sandeen
2013-04-25 14:07 ` Chandra Seetharaman
2013-04-25 21:44 ` Dave Chinner
2013-04-25 22:29 ` Chandra Seetharaman
2013-04-25 14:48 ` Brian Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130423210226.GN10481@dastard \
--to=david@fromorbit.com \
--cc=bfoster@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.