All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Allow U-Boot scripts to be placed in a .env file
Date: Tue, 23 Apr 2013 19:33:51 -0400	[thread overview]
Message-ID: <20130423233351.GL14952@bill-the-cat> (raw)
In-Reply-To: <CAPnjgZ067SDErCJ39u2PqajKzHTR9ZA2WEHHutk0ZoZCQF5rDg@mail.gmail.com>

On Tue, Apr 23, 2013 at 02:32:00PM -0700, Simon Glass wrote:
> Hi Wolfgang,
> 
> On Tue, Apr 16, 2013 at 10:44 PM, Wolfgang Denk <wd@denx.de> wrote:
> > Dear Simon Glass,
> >
> > In message <1366155414-6525-1-git-send-email-sjg@chromium.org> you wrote:
> >> At present U-Boot environment variables, and thus scripts, are defined
> >> by CONFIG_EXTRA_ENV_SETTINGS. It is painful to add large amounts of text
> >> to this file and dealing with quoting and newlines is harder than it
> >> should be. It would be better if we could just type the script into a
> >> text file and have it included by U-Boot.
> >>
> >> Add a feature that brings in a .env file associated with the board
> >> config, if present. To use it, create a file in include/configs
> >> with the same name as you could board config file, except with a
> >> .env extension instead of a .h extension. The variables should be
> >> separated by \0. Comments are permitted, using # as the first character
> >> in a line.
> >
> > Please do not litter the include/configs/ directory with such stuff.
> > It's more than big enough already.  Please put such files into the
> > respective board directories.
> 
> OK.
> 
> >
> > And if you do something like this, then please go the way to the end.
> > Forget about the \0 termination, make it a plain text file instead,
> > something that can be used with "env import -t" as well (or created
> > with "env export -t").
> 
> I'm not sure how to do this. Doesn't this mean that we cannot add
> multi-line scripts to the environment? That was part of my aim. But if
> I put a 0x0a in the script then it will think we are starting a new
> variable.

The first thing that pops to mind is:
1) embedded the text file into a linker-known spot
2) Make part of the default env setup process be to env import -t that
location in memory.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130423/f1de9dc1/attachment.pgp>

  reply	other threads:[~2013-04-23 23:33 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-16 23:36 [U-Boot] [PATCH] Allow U-Boot scripts to be placed in a .env file Simon Glass
2013-04-17  5:44 ` Wolfgang Denk
2013-04-17 22:26   ` Otavio Salvador
2013-04-23 21:32   ` Simon Glass
2013-04-23 23:33     ` Tom Rini [this message]
2013-04-24  0:29       ` Simon Glass
2013-04-24  2:14         ` Otavio Salvador
2013-04-24  2:36           ` Simon Glass
2013-04-24  2:44             ` Otavio Salvador
2013-04-24  3:05               ` Simon Glass
2013-04-24  3:20                 ` Otavio Salvador
2013-04-24  3:43                   ` Simon Glass
2013-04-24  5:36                   ` Wolfgang Denk
2013-04-26  8:34                     ` Smithlife
2013-04-24  5:34                 ` Wolfgang Denk
2013-05-06 13:02   ` Rob Herring
2013-05-06 13:14     ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130423233351.GL14952@bill-the-cat \
    --to=trini@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.