All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hedberg <johan.hedberg@gmail.com>
To: Vinicius Costa Gomes <vinicius.gomes@openbossa.org>
Cc: Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
	"linux-bluetooth@vger.kernel.org"
	<linux-bluetooth@vger.kernel.org>
Subject: Re: [RFC 1/2] gdbus: Add g_dbus_flush_properties()
Date: Wed, 24 Apr 2013 16:58:55 +0300	[thread overview]
Message-ID: <20130424135855.GA18679@x220> (raw)
In-Reply-To: <20130419133459.GA7044@echo>

Hi,

On Fri, Apr 19, 2013, Vinicius Costa Gomes wrote:
> On 09:30 Fri 19 Apr, Luiz Augusto von Dentz wrote:
> > What about creating a new flag for properties that need to emit a
> > signal immediately when they change?
> 
> That would also solve the problem.
> 
> The way I see it, we should still not make any guarantees about when
> a propery changed signal will be emitted, only when the API behaviour
> requires, we use some kind of barrier to keep the ordering in check.
> 
> And having a function to call we make it easier to detect when this
> is abused, i.e. we know there's something very wrong if there's a flush
> after each emit.

Is this where the discussion got stuck? Since this feature is really
only needed for quite exceptional situations if an API change needs to
be done I'd be in favor of a separate flush function.

Another option is to make *all* D-Bus messages that gdbus sends to use
an idle callback, including method calls and returns. In the idle
callback the messages would be sent in the same order as they were added
to the send queue. This would not require any changes to the gdbus API.

Johan

  reply	other threads:[~2013-04-24 13:58 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-18 17:50 [RFC 1/2] gdbus: Add g_dbus_flush_properties() Vinicius Costa Gomes
2013-04-18 17:50 ` [RFC 2/2] device: Fix the wrong order of UUIDs PropertyChanged Vinicius Costa Gomes
2013-04-19  6:30 ` [RFC 1/2] gdbus: Add g_dbus_flush_properties() Luiz Augusto von Dentz
2013-04-19 13:34   ` Vinicius Costa Gomes
2013-04-24 13:58     ` Johan Hedberg [this message]
2013-04-24 14:24       ` Vinicius Costa Gomes
2013-04-24 17:33       ` Lucas De Marchi
2013-04-24 17:56         ` Vinicius Costa Gomes
2013-04-24 18:09           ` Lucas De Marchi
2013-04-24 18:19             ` Vinicius Costa Gomes
2013-04-24 18:36         ` Johan Hedberg
2013-04-24 19:01           ` Lucas De Marchi
2013-04-24 20:14             ` Amro Mouslli
2013-06-26 19:11             ` João Paulo Rechi Vita
2013-06-26 19:49               ` Johan Hedberg
2013-06-26 22:09                 ` Lucas De Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130424135855.GA18679@x220 \
    --to=johan.hedberg@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    --cc=vinicius.gomes@openbossa.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.