From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60067) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UV1oS-0001RT-Lx for qemu-devel@nongnu.org; Wed, 24 Apr 2013 11:40:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UV1oQ-00077k-D7 for qemu-devel@nongnu.org; Wed, 24 Apr 2013 11:40:52 -0400 Date: Wed, 24 Apr 2013 17:40:13 +0200 From: Aurelien Jarno Message-ID: <20130424154013.GA4957@hall.aurel32.net> References: <1366768096-2846-1-git-send-email-lig.fnst@cn.fujitsu.com> <1366768096-2846-2-git-send-email-lig.fnst@cn.fujitsu.com> <1366787706.20507.10.camel@liguang.fnst.cn.fujitsu.com> <1366788738.20507.18.camel@liguang.fnst.cn.fujitsu.com> <1366789222.20507.20.camel@liguang.fnst.cn.fujitsu.com> <5177EA89.1080503@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5177EA89.1080503@suse.de> Sender: Aurelien Jarno Subject: Re: [Qemu-devel] [PATCH 2/2] target-*/cpu.h: remove cs_base for other targets List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?iso-8859-15?Q?F=E4rber?= Cc: Peter Maydell , jan.kiszka@siemens.com, green@moxielogic.com, qemu-devel@nongnu.org, blauwirbel@gmail.com, jcmvbkbc@gmail.com, edgar.iglesias@gmail.com, gxt@mprc.pku.edu.cn, proljc@gmail.com, agraf@suse.de, evgenyvoevodin@gmail.com, ehabkost@redhat.com, sw@weilnetz.de, paul@codesourcery.com, stefanha@redhat.com, imammedo@redhat.com, rth@twiddle.net, aliguori@us.ibm.com, Laurent@vivier.eu, michael@walle.cc, qemu-ppc@nongnu.org, pbonzini@redhat.com, li guang On Wed, Apr 24, 2013 at 04:22:01PM +0200, Andreas Färber wrote: > Am 24.04.2013 09:40, schrieb li guang: > > 在 2013-04-24三的 08:36 +0100，Peter Maydell写道： > >> On 24 April 2013 08:32, li guang wrote: > >>> I think even others want to use something like you said, > >>> it should not 'cs_base', or, it's a bad name. > >> > >> Yes, this is why I said "has a less than helpful name". > >> > >>>> > >>>>>>> --- a/target-sparc/cpu.h > >>>>>>> +++ b/target-sparc/cpu.h > >>>>>>> @@ -715,7 +715,7 @@ trap_state* cpu_tsptr(CPUSPARCState* env); > >>>>>>> #define TB_FLAG_AM_ENABLED (1 << 5) > >>>>>>> > >>>>>>> static inline void cpu_get_tb_cpu_state(CPUSPARCState *env, target_ulong *pc, > >>>>>>> - target_ulong *cs_base, int *flags) > >>>>>>> + int *flags) > >>>>>>> { > >>>>>>> *pc = env->pc; > >>>>>>> *cs_base = env->npc; > >> > >>>> You clearly have a problem with your compile and test > >>>> process then, because it is clear from the patch that > >>>> you've removed the cs_base argument from this function > >>>> but the function still has a use of 'cs_base' in it. > >>> > >>> ???, sorry, where do I miss 'cs_base' removing? > >> > >> Last quoted line of source: "*cs_base = env->npc". > > > > OK, thanks! > > that remove by overshoot script! > > Some general reminders: > > We're in Soft Freeze, so in general no new big patch series will go into > 1.5 unless there's a maintainer willing to take care of it - for i386 > there is none, and random code cleanups do not look like something we > must absolutely have in the release last minute. At least no one brought > up on yesterday's call that this is a must-have, so maybe after the > release would be a better time to let people review this? > Being in soft or hard freeze should not prevent people to send patches, and nothing here says that they should be included in 1.5. -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net