From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH 09/12] drm/i915: Split context enabling from
 init
Date: Wed, 24 Apr 2013 09:39:31 -0700
Message-ID: <20130424163931.GC7077@bwidawsk.net>
References: <1366784140-2670-1-git-send-email-ben@bwidawsk.net>
	<1366784140-2670-10-git-send-email-ben@bwidawsk.net>
	<20130424100440.GE11689@cantiga.alporthouse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from shiva.localdomain (unknown [209.20.75.48])
	by gabe.freedesktop.org (Postfix) with ESMTP id 0F6B6E5D0F
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 24 Apr 2013 09:37:03 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20130424100440.GE11689@cantiga.alporthouse.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>, Intel GFX <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Wed, Apr 24, 2013 at 11:04:40AM +0100, Chris Wilson wrote:
> On Tue, Apr 23, 2013 at 11:15:37PM -0700, Ben Widawsky wrote:
> > -	i915_gem_context_init(dev);
> > +	if (!dev_priv->hw_contexts_disabled &&
> > +	    i915_gem_context_enable(dev_priv)) {
> 
> Move the hw_contexts_disabled test into i915_gem_context_enable(), just
> makes this bit of code cleaner and less incestrous.
> -Chris

Got it locally, thanks for the idea. I'll wait a bit to resend in case
more review comes in.


> 
> -- 
> Chris Wilson, Intel Open Source Technology Centre

-- 
Ben Widawsky, Intel Open Source Technology Center