From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] dma: imx-sdma: move to generic device tree bindings
Date: Wed, 24 Apr 2013 16:52:48 +0200 [thread overview]
Message-ID: <201304241652.48951.arnd@arndb.de> (raw)
In-Reply-To: <20130424144318.GD2736@S2101-09.ap.freescale.net>
On Wednesday 24 April 2013, Shawn Guo wrote:
> Using macros will help us to:
>
> 1) Improve the readability of "dmas" property in dts
> 2) Keep the values stay in sync between kernel and DT
>
I can understand the second part, but I strongly disagree on the first one.
Using symbolic constants in the DT will make it harder to understand because
you now have to look in multiple places to see what you actually put in there.
It makes some sense for the priorities, since they get reused for each
dma specifier.
Arnd
next prev parent reply other threads:[~2013-04-24 14:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-24 14:04 [PATCH 0/2] dma: imx-sdma: add generic DMA device tree bindings support Shawn Guo
2013-04-24 14:04 ` [PATCH 1/2] dma: imx: change enum definitions to macros Shawn Guo
2013-04-24 14:04 ` [PATCH 2/2] dma: imx-sdma: move to generic device tree bindings Shawn Guo
2013-04-24 14:23 ` Fabio Estevam
2013-04-24 14:39 ` Shawn Guo
2013-04-24 14:26 ` Arnd Bergmann
2013-04-24 14:43 ` Shawn Guo
2013-04-24 14:52 ` Arnd Bergmann [this message]
2013-04-24 15:15 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201304241652.48951.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.