From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 04/10] usb: musb: ux500: harden checks for platform data
Date: Wed, 24 Apr 2013 16:56:53 +0200 [thread overview]
Message-ID: <201304241656.53432.arnd@arndb.de> (raw)
In-Reply-To: <CAF2Aj3ga7R3Vti4YB-83T_AsanB3iL34aysAN3MiMWZBvB=z2Q@mail.gmail.com>
On Wednesday 24 April 2013, Lee Jones wrote:
> Yeah, I agree, although does it make a difference?
>
> Is it evaluated a second time, or does it take up extra cycles by being
> enclosed in parentheses?
>
> Or is this just a coding style thing?
Just coding style. I agree you should have no parentheses there, but it
does not change the compiled code.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Lee Jones <lee.jones@linaro.org>
Cc: balbi@ti.com,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Linus Walleij <linus.walleij@stericsson.com>,
mian.yousaf.kaukab@stericsson.com, linux-usb@vger.kernel.org
Subject: Re: [PATCH 04/10] usb: musb: ux500: harden checks for platform data
Date: Wed, 24 Apr 2013 16:56:53 +0200 [thread overview]
Message-ID: <201304241656.53432.arnd@arndb.de> (raw)
In-Reply-To: <CAF2Aj3ga7R3Vti4YB-83T_AsanB3iL34aysAN3MiMWZBvB=z2Q@mail.gmail.com>
On Wednesday 24 April 2013, Lee Jones wrote:
> Yeah, I agree, although does it make a difference?
>
> Is it evaluated a second time, or does it take up extra cycles by being
> enclosed in parentheses?
>
> Or is this just a coding style thing?
Just coding style. I agree you should have no parentheses there, but it
does not change the compiled code.
Arnd
next prev parent reply other threads:[~2013-04-24 14:56 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-23 15:03 [PATCH 00/10] usb: musb: ux500: pathe the way for Device Tree enablement Lee Jones
2013-04-23 15:03 ` Lee Jones
2013-04-23 15:03 ` [PATCH 01/10] usb: musb: ux500: move channel number knowledge into the driver Lee Jones
2013-04-23 15:03 ` Lee Jones
2013-04-25 13:01 ` Linus Walleij
2013-04-25 13:01 ` Linus Walleij
2013-04-23 15:03 ` [PATCH 02/10] usb: musb: ux500: move the MUSB HDRC configuration " Lee Jones
2013-04-23 15:03 ` Lee Jones
2013-04-25 13:02 ` Linus Walleij
2013-04-25 13:02 ` Linus Walleij
2013-04-23 15:03 ` [PATCH 03/10] usb: musb: ux500: take the dma_mask from coherent_dma_mask Lee Jones
2013-04-23 15:03 ` Lee Jones
2013-04-25 13:04 ` Linus Walleij
2013-04-25 13:04 ` Linus Walleij
2013-04-23 15:03 ` [PATCH 04/10] usb: musb: ux500: harden checks for platform data Lee Jones
2013-04-23 15:03 ` Lee Jones
2013-04-23 20:03 ` Sergei Shtylyov
2013-04-23 20:03 ` Sergei Shtylyov
2013-04-24 6:53 ` Lee Jones
2013-04-24 6:53 ` Lee Jones
2013-04-24 14:00 ` Sergei Shtylyov
2013-04-24 14:00 ` Sergei Shtylyov
2013-04-24 14:26 ` Felipe Balbi
2013-04-24 14:26 ` Felipe Balbi
[not found] ` <CAF2Aj3ga7R3Vti4YB-83T_AsanB3iL34aysAN3MiMWZBvB=z2Q@mail.gmail.com>
2013-04-24 14:56 ` Arnd Bergmann [this message]
2013-04-24 14:56 ` Arnd Bergmann
2013-04-24 15:04 ` [PATCH 04/10 v2] " Lee Jones
2013-04-24 15:04 ` Lee Jones
2013-04-25 13:06 ` Linus Walleij
2013-04-25 13:06 ` Linus Walleij
2013-04-23 15:03 ` [PATCH 05/10] usb: musb: ux500: attempt to find channels by name before using pdata Lee Jones
2013-04-23 15:03 ` Lee Jones
2013-04-24 15:05 ` [PATCH 05/10 v2] " Lee Jones
2013-04-24 15:05 ` Lee Jones
2013-04-25 13:08 ` Linus Walleij
2013-04-25 13:08 ` Linus Walleij
2013-04-23 15:03 ` [PATCH 06/10] usb: musb: ux500: add device tree probing support Lee Jones
2013-04-23 15:03 ` Lee Jones
2013-04-23 15:14 ` Arnd Bergmann
2013-04-23 15:14 ` Arnd Bergmann
2013-04-23 15:15 ` Felipe Balbi
2013-04-23 15:15 ` Felipe Balbi
2013-04-23 15:27 ` Arnd Bergmann
2013-04-23 15:27 ` Arnd Bergmann
2013-04-23 15:29 ` Felipe Balbi
2013-04-23 15:29 ` Felipe Balbi
2013-04-24 7:43 ` [PATCH 06/10 v2] " Lee Jones
2013-04-24 7:43 ` Lee Jones
2013-04-25 13:12 ` Linus Walleij
2013-04-25 13:12 ` Linus Walleij
2013-04-23 15:03 ` [PATCH 07/10] ARM: ux500: Add an auxdata entry for MUSB for clock-name look-up Lee Jones
2013-04-23 15:03 ` Lee Jones
2013-04-25 13:13 ` Linus Walleij
2013-04-25 13:13 ` Linus Walleij
2013-04-23 15:03 ` [PATCH 08/10] ARM: ux500: Populate the ux500-musb Device Tree entry Lee Jones
2013-04-23 15:03 ` Lee Jones
2013-04-24 7:41 ` [PATCH 08/10 v2] " Lee Jones
2013-04-24 7:41 ` Lee Jones
2013-04-25 13:14 ` Linus Walleij
2013-04-25 13:14 ` Linus Walleij
2013-04-23 15:03 ` [PATCH 09/10] ARM: ux500: Remove ux500-musb platform registation when booting with DT Lee Jones
2013-04-23 15:03 ` Lee Jones
2013-04-25 13:15 ` Linus Walleij
2013-04-25 13:15 ` Linus Walleij
2013-05-02 10:52 ` Lee Jones
2013-05-02 10:52 ` Lee Jones
2013-04-23 15:03 ` [PATCH 10/10] ARM: ux500: Remove empty function u8500_of_init_devices() Lee Jones
2013-04-23 15:03 ` Lee Jones
2013-04-25 13:16 ` Linus Walleij
2013-04-25 13:16 ` Linus Walleij
2013-05-02 10:52 ` Lee Jones
2013-05-02 10:52 ` Lee Jones
2013-04-23 15:16 ` [PATCH 00/10] usb: musb: ux500: pathe the way for Device Tree enablement Arnd Bergmann
2013-04-23 15:16 ` Arnd Bergmann
2013-04-26 13:49 ` Fabio Baltieri
2013-04-26 13:49 ` Fabio Baltieri
2013-04-26 15:19 ` Lee Jones
2013-04-26 15:19 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201304241656.53432.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.