From: Jonathan Nieder <jrnieder@gmail.com>
To: Ramkumar Ramachandra <artagnon@gmail.com>
Cc: Git List <git@vger.kernel.org>, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 4/5] git-diff.txt: document the .. and ... forms in SYNOPSIS
Date: Wed, 24 Apr 2013 12:03:17 -0700 [thread overview]
Message-ID: <20130424190317.GD29963@google.com> (raw)
In-Reply-To: <1366821216-20868-5-git-send-email-artagnon@gmail.com>
Ramkumar Ramachandra wrote:
> --- a/Documentation/git-diff.txt
> +++ b/Documentation/git-diff.txt
> @@ -13,6 +13,8 @@ SYNOPSIS
> 'git diff' [options] --cached [<commit>] [[--] [<path>...]]
> 'git diff' [options] <blob> <blob>
> 'git diff' [options] <commit> <commit> [[--] [<path>...]]
> +'git diff' [options] <commit>..<commit> [[--] [<path>...]]
> +'git diff' [options] <commit>\...<commit> [[--] [<path>...]]
> 'git diff' [options] [--no-index] [[--] <path> <path>]
This is preparation for removing <commit>..<commit> from the
documentation, right? It makes sense to add the ... form since
there's no other way to spell it but I can't say I'm excited about
adding the .. form. Especially since <tree>..<tree> doesn't work,
that form's a little embarrassing. ;-)
*checks the manpage*
Ah, this is to make the SYNOPSIS a better table of contents for the
DESCRIPTION (except that the DESCRIPTION treats "git diff --no-index
<path> <path>" before "git diff [<commit>] -- <pathspec>" while the
SYNOPSIS doesn't). Maybe it would make sense to go all the way and
make the two follow the same order?
My 2¢,
Jonathan
next prev parent reply other threads:[~2013-04-24 19:03 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-24 16:33 [PATCH 0/5] Documentation/git-diff.txt improvements Ramkumar Ramachandra
2013-04-24 16:33 ` [PATCH 1/5] git-diff.txt: reorder the <commit> <commit> form Ramkumar Ramachandra
2013-04-24 16:41 ` Jonathan Nieder
2013-04-24 16:33 ` [PATCH 2/5] git-diff.txt: strip the leading "--" from options template Ramkumar Ramachandra
2013-04-24 16:43 ` Jonathan Nieder
2013-04-24 16:44 ` Ramkumar Ramachandra
2013-04-24 18:15 ` Junio C Hamano
2013-04-24 16:33 ` [PATCH 3/5] git-diff.txt: group the [--] and [<path>...] templates Ramkumar Ramachandra
2013-04-24 18:20 ` Junio C Hamano
2013-04-24 18:23 ` Ramkumar Ramachandra
2013-04-24 18:43 ` Junio C Hamano
2013-04-24 18:53 ` Ramkumar Ramachandra
2013-04-24 19:21 ` Junio C Hamano
2013-04-24 19:24 ` Ramkumar Ramachandra
2013-04-24 18:57 ` Jonathan Nieder
2013-04-24 16:33 ` [PATCH 4/5] git-diff.txt: document the .. and ... forms in SYNOPSIS Ramkumar Ramachandra
2013-04-24 19:03 ` Jonathan Nieder [this message]
2013-04-24 16:33 ` [PATCH 5/5] git-diff.txt: fix ordering of the [--no-index] form Ramkumar Ramachandra
2013-04-24 18:25 ` Junio C Hamano
2013-04-24 18:29 ` Ramkumar Ramachandra
2013-04-24 19:06 ` Jonathan Nieder
2013-04-24 19:10 ` Ramkumar Ramachandra
2013-04-24 19:14 ` Jonathan Nieder
2013-04-24 19:20 ` Ramkumar Ramachandra
2013-04-24 19:25 ` Jonathan Nieder
2013-04-24 19:37 ` Ramkumar Ramachandra
2013-04-24 20:37 ` Jonathan Nieder
2013-04-24 20:45 ` Ramkumar Ramachandra
2013-04-24 20:50 ` Jonathan Nieder
2013-04-24 20:55 ` Ramkumar Ramachandra
2013-04-24 17:03 ` [PATCH 6/5] git-diff.txt: banish the <commit>..<commit> form Ramkumar Ramachandra
2013-04-24 18:29 ` Junio C Hamano
2013-04-24 18:33 ` Ramkumar Ramachandra
2013-04-25 11:25 ` [PATCH 0/5] Documentation/git-diff.txt improvements Ramkumar Ramachandra
2013-04-29 16:33 ` Junio C Hamano
2013-04-29 17:19 ` Ramkumar Ramachandra
2013-04-29 17:40 ` Junio C Hamano
2013-04-29 18:28 ` Ramkumar Ramachandra
2013-04-29 18:46 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130424190317.GD29963@google.com \
--to=jrnieder@gmail.com \
--cc=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.