From: Mike Snitzer <snitzer@redhat.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org
Subject: Re: sd: workaround invalid OPTIMAL TRANSFER LENGTH
Date: Wed, 24 Apr 2013 21:44:55 -0400 [thread overview]
Message-ID: <20130425014455.GA28078@redhat.com> (raw)
In-Reply-To: <yq1bo93v230.fsf@sermon.lab.mkp.net>
On Wed, Apr 24 2013 at 9:19pm -0400,
Martin K. Petersen <martin.petersen@oracle.com> wrote:
> >>>>> "Mike" == Mike Snitzer <snitzer@redhat.com> writes:
>
> Mike,
>
> Following up on our discussion at LSF/MM last week...
>
> Mike> Workaround disk firmware that improperly sets OPTIMAL TRANSFER
> Mike> LENGTH to 0xFFFFFFFF (aka UINT_MAX or 4294967295U) by assuming
> Mike> this _optional_ BLOCK LIMITS VPD field was not specified (0).
>
> My only real objection is that UINT_MAX appears to be completely
> coincidental. What if the next drive specifies UINT_MAX-1 or $RANDOM?
>
> Lacking a decent heuristic I'd rather just blacklist the offending drive
> using the skip_vpd_pages knob we already have in place.
OK, sounds fine to me, thanks.
prev parent reply other threads:[~2013-04-25 1:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-03 20:21 [PATCH] [SCSI] sd: workaround invalid OPTIMAL TRANSFER LENGTH Mike Snitzer
2013-04-03 20:38 ` Ewan Milne
2013-04-25 1:19 ` Martin K. Petersen
2013-04-25 1:44 ` Mike Snitzer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130425014455.GA28078@redhat.com \
--to=snitzer@redhat.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.