On Thu, Apr 25, 2013 at 12:00:26AM +0200, Laurent Pinchart wrote:

> As the same register is also used for pin control purposes there is no
> way to achieve atomic read/write sequences with a separate regulator
> driver. We thus need to implement the regulator here.

You could use an MMIO regmap providing the performance isn't critical
enough for that to cause problems.

But this looks basically OK if we can't do that for some reason.

Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>