From: Stephen Hemminger <stephen@networkplumber.org>
To: Alexander Duyck <alexander.h.duyck@intel.com>
Cc: shemminger@vyatta.com, netdev@vger.kernel.org,
jeffrey.t.kirsher@intel.com, Jamal Hadi Salim <jhs@mojatatu.com>,
Hasan Chowdhury <shemonc@gmail.com>
Subject: Re: [IPROUTE PATCH] iproute2: act_ipt fix xtables breakage on older versions.
Date: Thu, 25 Apr 2013 16:16:24 -0700 [thread overview]
Message-ID: <20130425161624.68fa65b3@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <20130425220716.6520.94862.stgit@ahduyck-cp1.jf.intel.com>
On Thu, 25 Apr 2013 15:07:16 -0700
Alexander Duyck <alexander.h.duyck@intel.com> wrote:
> In trying to build on a RHEL6.3 I ran into several build issues that are
> addressed in this patch.
>
> The first is that xtables_options_xfrm only has 3 options. It appears this is
> how this code was originally. As such for the case where the version is less
> than 6 I am assuming it would be correct to maintain the original setup that
> only had 3 parameters being passed instead of 4.
>
> I also ran into an issue with the define for __ALIGN_KERNEL not being present.
> I believe this may be due to the fact that __ALIGN_KERNEL was moved into a
> separate header from ALIGN after the uapi changes. In order to just cover all
> of the bases I have moved the main definition for the macros into
> __ALIGN_KERNEL_MASK and __ALIGN_KERNEL and if ALIGN is also needed then it is
> just a direct redefine to __ALIGN_KERNEL.
>
> Cc: Hasan Chowdhury <shemonc@gmail.com>
> Cc: Jamal Hadi Salim <jhs@mojatatu.com>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
I want some feedback from Jamal and libxt netfilter experts.
This code has been fragile in the past.
next prev parent reply other threads:[~2013-04-25 23:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-25 22:07 [IPROUTE PATCH] iproute2: act_ipt fix xtables breakage on older versions Alexander Duyck
2013-04-25 23:16 ` Stephen Hemminger [this message]
2013-04-26 13:20 ` Jamal Hadi Salim
2013-04-26 15:58 ` Alexander Duyck
2013-04-28 14:31 ` Jamal Hadi Salim
2013-04-28 20:53 ` Alexander Duyck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130425161624.68fa65b3@nehalam.linuxnetplumber.net \
--to=stephen@networkplumber.org \
--cc=alexander.h.duyck@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
--cc=shemonc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.