Re: [PATCH v2 3/3] hfp_hf_bluez5: Register the SDP record with correct features

[Vinicius Costa Gomes <vinicius.gomes@openbossa.org>]

[-- Attachment #1: Type: text/plain, Size: 1731 bytes --]

Hi Denis,

On 03:41 Thu 25 Apr, Denis Kenzior wrote:
> Hi Vinicius,
> 
> On 04/23/2013 04:21 PM, Vinicius Costa Gomes wrote:
> >---
> >  plugins/hfp_hf_bluez5.c | 7 ++++++-
> >  1 file changed, 6 insertions(+), 1 deletion(-)
> >
> 
> Patch has been applied, thanks.
> 
> >diff --git a/plugins/hfp_hf_bluez5.c b/plugins/hfp_hf_bluez5.c
> >index 826796f..06b6fd3 100644
> >--- a/plugins/hfp_hf_bluez5.c
> >+++ b/plugins/hfp_hf_bluez5.c
> >@@ -636,10 +636,15 @@ static const GDBusMethodTable profile_methods[] = {
> >
> >  static void connect_handler(DBusConnection *conn, void *user_data)
> >  {
> >+	uint16_t features = HFP_SDP_HF_FEATURE_3WAY |
> >+				HFP_SDP_HF_FEATURE_CLIP |
> >+				HFP_SDP_HF_FEATURE_REMOTE_VOLUME_CONTROL |
> >+				HFP_SDP_HF_FEATURE_WIDEBAND_SPEECH;
> >+
> 
> Can we check whether the kernel supports wideband speech features
> here and not set this flag if it does not?

What we can do is exporting something like
ofono_handsfree_audio_has_defer_setup() or something like it, and set the
feature bit if it's available. I send the patches and let's see how it looks.

The other alternative would be only registering the profile after the Agent
registers, that way we can be sure that wideband speech is supported. But it
may bring little benefit, for example, the other side may cache the SDP search
results.

> 
> >  	DBG("Registering External Profile handler ...");
> >
> >  	bt_register_profile(conn, HFP_HS_UUID, HFP_VERSION_1_6, "hfp_hf",
> >-					HFP_EXT_PROFILE_PATH, NULL, 0);
> >+					HFP_EXT_PROFILE_PATH, NULL, features);
> >  }
> >
> >  static gboolean has_hfp_ag_uuid(DBusMessageIter *array)
> 
> Regards,
> -Denis


Cheers,
-- 
Vinicius