From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2 6/6] arm: mx5: Add support for DENX M53EVK
Date: Thu, 25 Apr 2013 22:12:40 +0200 [thread overview]
Message-ID: <201304252212.40808.marex@denx.de> (raw)
In-Reply-To: <CAOMZO5CEPMdMfFpFFUx+rd0nZ1Hm-fTsX3fZcvYK309K5h-0HA@mail.gmail.com>
Dear Fabio Estevam,
[..]
> >> Shouldn't this function be placed into a common mx5 location? mx53ard
> >> uses the same.
> >
> > The WEIM and M4IF configuration is board-specific.
>
> Right, understood. It seems like a duplication of code from mx53ard,
> but anyway, what about:
>
> clrbits_le32(WEIM_BASE_ADDR + i, WEIM_GCR2_MUX16_BYP_GRANT) ?
>
> Accessing registers via offsets is not the best practice in U-boot.
>
> What about the weim struct defined at
> arch/arm/include/asm/arch-mx5/imx-regs.h
>
> for acessing such registers?
Yes, I agree, but you won't be able to do that in a loop as above if accessed
via struct-based access so I'm keeping this.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-04-25 20:12 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-21 15:52 [U-Boot] [PATCH V2 1/6] imx: Align the imximage header and payload to multiples of 4k Marek Vasut
2013-04-21 15:52 ` [U-Boot] [PATCH V2 2/6] nand: Add SPL_NAND support to mxc_nand_spl Marek Vasut
2013-04-22 22:57 ` Scott Wood
2013-04-21 15:52 ` [U-Boot] [PATCH V2 3/6] arm: imx: Pack u-boot.bin into uImage for SPL Marek Vasut
2013-04-21 15:52 ` [U-Boot] [PATCH 4/6] arm: mx5: Add SPL support code to MX5 Marek Vasut
2013-04-21 15:52 ` [U-Boot] [PATCH 5/6] arm: mx5: Add NAND clock handling Marek Vasut
2013-04-21 15:52 ` [U-Boot] [PATCH V2 6/6] arm: mx5: Add support for DENX M53EVK Marek Vasut
2013-04-21 17:16 ` Benoît Thébaudeau
2013-04-21 19:12 ` Marek Vasut
2013-04-21 19:46 ` Benoît Thébaudeau
2013-04-21 20:29 ` Marek Vasut
2013-04-24 7:39 ` Stefano Babic
2013-04-24 10:59 ` Benoît Thébaudeau
2013-04-25 7:31 ` Stefano Babic
2013-04-25 8:38 ` Stefan Roese
2013-04-25 12:31 ` Stefano Babic
2013-04-25 12:38 ` Marek Vasut
2013-04-25 12:48 ` Stefan Roese
2013-04-25 12:49 ` Benoît Thébaudeau
2013-04-25 13:02 ` Stefano Babic
2013-04-25 13:16 ` Benoît Thébaudeau
2013-04-25 13:31 ` Stefano Babic
2013-04-25 13:46 ` Stefan Roese
2013-04-25 14:12 ` Marek Vasut
2013-04-25 13:00 ` Stefano Babic
2013-04-24 18:52 ` Marek Vasut
2013-04-25 7:20 ` Stefano Babic
2013-04-25 13:36 ` Marek Vasut
2013-04-25 14:45 ` Stefano Babic
2013-04-25 14:54 ` Marek Vasut
2013-04-24 19:04 ` Fabio Estevam
2013-04-24 21:32 ` Marek Vasut
2013-04-24 21:44 ` Otavio Salvador
2013-04-25 0:55 ` Fabio Estevam
2013-04-25 20:12 ` Marek Vasut [this message]
2013-05-05 15:59 ` [U-Boot] [PATCH V2 1/6] imx: Align the imximage header and payload to multiples of 4k Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201304252212.40808.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.