All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Li Fei <fei.li@intel.com>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
	x86@kernel.org, chuansheng.liu@intel.com,
	tomoki.sekiyama.qu@hitachi.com, suresh.b.siddha@intel.com,
	joe@perches.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: eliminate irq_mis_count counted in arch_irq_stat
Date: Fri, 26 Apr 2013 10:19:15 +0200	[thread overview]
Message-ID: <20130426081915.GA1450@gmail.com> (raw)
In-Reply-To: <1366962971.32469.4.camel@fli24-HP-Compaq-8100-Elite-CMT-PC>


* Li Fei <fei.li@intel.com> wrote:

> 
> With current implementation, kstat_cpu(cpu).irqs_sum is also
> increased in case of irq_mis_count increment.
> So there is no need to count irq_mis_count in arch_irq_stat,
> otherwise irq_mis_count will be counted twice in the sum of
> /proc/stat.
> 
> Signed-off-by: Liu Chuansheng <chuansheng.liu@intel.com>
> Signed-off-by: Li Fei <fei.li@intel.com>

The patch looks good, but this is not a valid signoff sequence. If Liu 
Chuansheng wrote this patch then his From: line should be included. If he 
acked it, then it should be added as Acked-by.

Thanks,

	Ingo

  reply	other threads:[~2013-04-26  8:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-26  7:56 [PATCH] x86: eliminate irq_mis_count counted in arch_irq_stat Li Fei
2013-04-26  8:19 ` Ingo Molnar [this message]
2013-04-26  8:44   ` Li, Fei
2013-04-26  9:33     ` Ingo Molnar
2013-04-26 12:50 ` [PATCH V2] " Li Fei
2013-04-30 16:45   ` [tip:perf/urgent] x86: Eliminate " tip-bot for Li Fei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130426081915.GA1450@gmail.com \
    --to=mingo@kernel.org \
    --cc=chuansheng.liu@intel.com \
    --cc=fei.li@intel.com \
    --cc=hpa@zytor.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=suresh.b.siddha@intel.com \
    --cc=tglx@linutronix.de \
    --cc=tomoki.sekiyama.qu@hitachi.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.