All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Myers <bpm@sgi.com>
To: Chandra Seetharaman <sekharan@us.ibm.com>
Cc: XFS mailing list <xfs@oss.sgi.com>
Subject: Re: xfs module insert fails with "xfs: Unknown symbol exportfs_decode_fh (err 0)"
Date: Fri, 26 Apr 2013 13:16:24 -0500	[thread overview]
Message-ID: <20130426181624.GG29359@sgi.com> (raw)
In-Reply-To: <1366997050.4098.14.camel@chandra-dt.ibm.com>

Hey Chandra,

On Fri, Apr 26, 2013 at 12:24:09PM -0500, Chandra Seetharaman wrote:
> When I tried to insert xfs module in my test machine it failed with 
> 
> 	xfs: Unknown symbol exportfs_decode_fh (err 0).
> 
> Found out that I did not have CONFIG_EXPORTFS enabled in my kernel
> config. 

Most people are running with NFS enabled in their kernel config, I think.

> All .*by_handle code in XFS is open coded. Wondering if they should be
> under #ifdef CONFIG_EXPORTFS ?
>
> I can create a patch, but wanted to find out if it is indeed needed :)

foo_by_handle
  xfs_handlereq_to_dentry
    xfs_handle_to_dentry
      exportfs_decode_fh

xfsdump does open by handle, so making that conditional on CONFIG_EXPORTFS will
break things.  I think would be better to just make CONFIG_XFS depend upon
CONFIG_EXPORTFS in fs/xfs/Kconfig.  Looks like we'll have the same problem with
libcrc32c.

Regards,
	Ben

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  parent reply	other threads:[~2013-04-26 18:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-26 17:24 xfs module insert fails with "xfs: Unknown symbol exportfs_decode_fh (err 0)" Chandra Seetharaman
2013-04-26 18:02 ` Eric Sandeen
2013-04-26 18:29   ` Chandra Seetharaman
2013-04-26 18:16 ` Ben Myers [this message]
2013-04-26 21:46   ` Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130426181624.GG29359@sgi.com \
    --to=bpm@sgi.com \
    --cc=sekharan@us.ibm.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.