From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick Welche Subject: Re: [PATCH] FIX: Cast the time_t values to avoid warnings Date: Sat, 27 Apr 2013 21:18:03 +0100 Message-ID: <20130427201803.GA17211@quantz> References: <1367092353-22130-1-git-send-email-7heo@7heo.tk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1367092353-22130-1-git-send-email-7heo@7heo.tk> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: 7heo <7heo@7heo.tk> Cc: xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Sat, Apr 27, 2013 at 09:52:33PM +0200, 7heo wrote: > I added 4 casts from time_t to unsigned long int > in the libxl_sprintf functions, so there is no > warning at compilation time (and no failing with > -Werror). > > The casting format has been discuted, and since > there is no system having a 8 byte time_t format > yet; unsigned long int should be sufficient. > Also, it matches the libxl_sprintf syntax (%lu). I thought that earlier in the thread someone pointed out that unsigned long long would be a better plan? (long could just be 32 bits long) Cheers, Patrick